expression: fix compatibility behaviors in zero datetime with MySQL#21220
Merged
lzmhhh123 merged 14 commits intopingcap:masterfrom Dec 7, 2020
Merged
expression: fix compatibility behaviors in zero datetime with MySQL#21220lzmhhh123 merged 14 commits intopingcap:masterfrom
lzmhhh123 merged 14 commits intopingcap:masterfrom
Conversation
Contributor
Author
|
/cc @qw4990 |
Contributor
Author
|
/cc @ichn-hu |
Contributor
Author
|
/run-all-tests |
Closed
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-unit-test |
wshwsh12
reviewed
Dec 3, 2020
Contributor
wshwsh12
left a comment
There was a problem hiding this comment.
I think vectorized code should also be modified.
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
wshwsh12
reviewed
Dec 4, 2020
Contributor
wshwsh12
left a comment
There was a problem hiding this comment.
(b *builtinExtractDatetimeSig) vecEvalInt should also be modified.
Contributor
Author
No, |
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
Contributor
|
lgtm |
ti-srebot
approved these changes
Dec 7, 2020
|
There is no reward for this challenge pull request, so you can request a reward from @SunRunAway. |
Contributor
Author
|
/merge |
Contributor
|
/run-all-tests |
Contributor
|
@lzmhhh123 merge failed. |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Dec 7, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
|
cherry pick to release-3.0 in PR #21524 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Dec 7, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
|
cherry pick to release-4.0 in PR #21525 |
asiafrank
pushed a commit
to asiafrank/tidb
that referenced
this pull request
Dec 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9728
What is changed and how it works?
How it Works:
Related changes
Check List
Tests
Side effects
Release note