Skip to content

expression: fix compatibility behaviors in zero datetime with MySQL (#21220)#21525

Merged
ti-srebot merged 4 commits intopingcap:release-4.0from
ti-srebot:release-4.0-0deb0a3426bc
Jan 26, 2021
Merged

expression: fix compatibility behaviors in zero datetime with MySQL (#21220)#21525
ti-srebot merged 4 commits intopingcap:release-4.0from
ti-srebot:release-4.0-0deb0a3426bc

Conversation

@ti-srebot
Copy link
Contributor

cherry-pick #21220 to release-4.0


What problem does this PR solve?

Issue Number: close #9728

What is changed and how it works?

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • fix compatibility behaviors in zero datetime with MySQL.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@lzmhhh123 you're already a collaborator in bot's repo.

Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@lzmhhh123
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 7, 2020
ichn-hu
ichn-hu previously approved these changes Dec 7, 2020
Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 7, 2020
@jebter jebter modified the milestones: 4.0.0, v4.0.10 Jan 7, 2021
@jebter jebter modified the milestones: v4.0.10, v4.0.11 Jan 18, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jan 26, 2021

Please resolve conflicts; @lzmhhh123

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jan 26, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jan 26, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2021
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 22481
  • 21628
  • 21142
  • 21936
  • 21874
  • 20981
  • 21464
  • 21483

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 12d2482 into pingcap:release-4.0 Jan 26, 2021
@lzmhhh123 lzmhhh123 deleted the release-4.0-0deb0a3426bc branch January 27, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug. type/4.0-cherry-pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants