Skip to content

planner, expression: set correct for ctx in isNullRejected#16430

Merged
XuHuaiyu merged 4 commits intopingcap:masterfrom
XuHuaiyu:issue16419
Apr 16, 2020
Merged

planner, expression: set correct for ctx in isNullRejected#16430
XuHuaiyu merged 4 commits intopingcap:masterfrom
XuHuaiyu:issue16419

Conversation

@XuHuaiyu
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #16419

Problem Summary:
ctx is passed as nil wrongly for PushDownNot.

What is changed and how it works?

Set the correct ctx for PushDownNot

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Side effects

N/A

Release note

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. sig/planner SIG: Planner needs-cherry-pick-4.0 labels Apr 15, 2020
@XuHuaiyu XuHuaiyu requested review from a team as code owners April 15, 2020 12:59
@ghost ghost requested review from a team, SunRunAway and lzmhhh123 and removed request for a team April 15, 2020 12:59
@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #16430 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #16430   +/-   ##
===========================================
  Coverage   80.3968%   80.3968%           
===========================================
  Files           506        506           
  Lines        136570     136570           
===========================================
  Hits         109798     109798           
  Misses        18209      18209           
  Partials       8563       8563           

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Apr 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

@XuHuaiyu merge failed.

@XuHuaiyu XuHuaiyu merged commit eeffe1e into pingcap:master Apr 16, 2020
@XuHuaiyu XuHuaiyu deleted the issue16419 branch April 16, 2020 08:25
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 16, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

cherry pick to release-4.0 in PR #16472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NATURAL LEFT JOIN with a NOT predicate results in a server panic

4 participants