Skip to content

planner, expression: set correct for ctx in isNullRejected (#16430)#16472

Merged
zz-jason merged 4 commits intopingcap:release-4.0from
sre-bot:release-4.0-eeffe1e26f46
Apr 24, 2020
Merged

planner, expression: set correct for ctx in isNullRejected (#16430)#16472
zz-jason merged 4 commits intopingcap:release-4.0from
sre-bot:release-4.0-eeffe1e26f46

Conversation

@sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 16, 2020

cherry-pick #16430 to release-4.0

What problem does this PR solve?

Issue Number: close #16419

Problem Summary:
ctx is passed as nil wrongly for PushDownNot.

What is changed and how it works?

Set the correct ctx for PushDownNot

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Side effects

N/A

Release note

@XuHuaiyu @sre-bot
cherry pick pingcap#16430 to release-4.0
7e922ad 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot requested review from a team as code owners April 16, 2020 08:26
@ghost ghost requested review from XuHuaiyu and winoros April 16, 2020 08:27
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 16, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Apr 16, 2020
Merged
@sre-bot sre-bot requested review from SunRunAway and lzmhhh123 April 16, 2020 08:27
zz-jason
zz-jason reviewed Apr 22, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XuHuaiyu please resolve conflict and fix CI.

@XuHuaiyu XuHuaiyu added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Apr 24, 2020
@XuHuaiyu XuHuaiyu requested review from SunRunAway and zz-jason April 24, 2020 10:40
zz-jason
zz-jason reviewed Apr 24, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Apr 24, 2020

/run-all-tests

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 24, 2020
SunRunAway
SunRunAway approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 24, 2020
@SunRunAway SunRunAway added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 24, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 24, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 24, 2020

@sre-bot merge failed.

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Apr 24, 2020

/run-sqllogic-test

@zz-jason zz-jason merged commit 03c46d2 into pingcap:release-4.0 Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zz-jason zz-jason zz-jason left review comments

+1 more reviewer

@SunRunAway SunRunAway SunRunAway approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@XuHuaiyu XuHuaiyu

Labels

component/expression priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sre-bot @XuHuaiyu @SunRunAway @zz-jason