planner: push aggregation functions with distinct to cop#15500
Merged
SunRunAway merged 28 commits intopingcap:masterfrom Apr 1, 2020
Merged
planner: push aggregation functions with distinct to cop#15500SunRunAway merged 28 commits intopingcap:masterfrom
SunRunAway merged 28 commits intopingcap:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15500 +/- ##
===========================================
Coverage 80.6949% 80.6949%
===========================================
Files 505 505
Lines 136208 136208
===========================================
Hits 109913 109913
Misses 17810 17810
Partials 8485 8485 |
bdb4415 to
ed5e7e6
Compare
Contributor
Author
|
/run-all-tests |
d861858 to
e4a8b94
Compare
winoros
approved these changes
Apr 1, 2020
Member
|
/run-all-tests |
Member
|
/run-check_dev_2 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 1, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Contributor
|
cherry pick to release-3.1 in PR #15974 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 1, 2020
Contributor
|
cherry pick to release-4.0 in PR #15975 |
sre-bot
added a commit
that referenced
this pull request
Apr 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #14623
Problem Summary:
When variable
tidb_opt_distinct_agg_push_downis set to1, TiDB can push down the DISTINCT part of COUNT DISTINCT(or SUM DISTINCT, etc) into coprocessor.What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Planner:
Performance tested w/ TiFlash:
Low NDV (right scenario),
High NDV (bad scenario),
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note
tidb_opt_distinct_agg_push_downis set to1