planner: push aggregation functions with distinct to cop (#15500)#15974
Closed
sre-bot wants to merge 1 commit intopingcap:release-3.1from
Closed
planner: push aggregation functions with distinct to cop (#15500)#15974sre-bot wants to merge 1 commit intopingcap:release-3.1from
sre-bot wants to merge 1 commit intopingcap:release-3.1from
Conversation
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Contributor
Author
|
/run-all-tests |
zz-jason
reviewed
Apr 1, 2020
Member
zz-jason
left a comment
There was a problem hiding this comment.
@SunRunAway please resolve conflicts.
Contributor
|
It's hard to pick to release 3.1. Closing it right now. If anyone needs this feature with this branch, feel free to contact me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #15500 to release-3.1
What problem does this PR solve?
Issue Number: close #14623
Problem Summary:
When variable
tidb_opt_distinct_agg_push_downis set to1, TiDB can push down the DISTINCT part of COUNT DISTINCT(or SUM DISTINCT, etc) into coprocessor.What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Planner:
Performance tested w/ TiFlash:
Low NDV (right scenario),
High NDV (bad scenario),
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note
tidb_opt_distinct_agg_push_downis set to1