Skip to content

distsql: fix wrong schema version when snapshot has been set#15258

Merged
lzmhhh123 merged 10 commits intopingcap:masterfrom
lzmhhh123:bug-fix/respect_tidb_snapshot
Mar 30, 2020
Merged

distsql: fix wrong schema version when snapshot has been set#15258
lzmhhh123 merged 10 commits intopingcap:masterfrom
lzmhhh123:bug-fix/respect_tidb_snapshot

Conversation

@lzmhhh123
Copy link
Contributor

What problem does this PR solve?

As the title says.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch (release-3.1

@lzmhhh123 lzmhhh123 added type/bugfix This PR fixes a bug. sig/execution SIG execution needs-cherry-pick-3.1 labels Mar 10, 2020
@lzmhhh123 lzmhhh123 requested a review from a team as a code owner March 10, 2020 07:28
@ghost ghost requested review from SunRunAway and wshwsh12 and removed request for a team March 10, 2020 07:28
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Mar 10, 2020
@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #15258 into master will not change coverage by %.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #15258   +/-   ##
===========================================
  Coverage   80.4142%   80.4142%           
===========================================
  Files           504        504           
  Lines        134787     134787           
===========================================
  Hits         108388     108388           
  Misses        17908      17908           
  Partials       8491       8491           

@wshwsh12 wshwsh12 changed the title dissql: fix wrong schema version when snapshot has been set distsql: fix wrong schema version when snapshot has been set Mar 15, 2020
@lzmhhh123 lzmhhh123 added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Mar 30, 2020
@lzmhhh123 lzmhhh123 requested a review from SunRunAway March 30, 2020 12:14
@lzmhhh123
Copy link
Contributor Author

/run-unit-test

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2020
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/can-merge Indicates a PR has been approved by a committer. label Mar 30, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

Your auto merge job has been accepted, waiting for 15817, 15851, 15849, 15709, 15621, 15865

@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

@lzmhhh123 merge failed.

@lzmhhh123
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

Your auto merge job has been accepted, waiting for 15676

@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

@lzmhhh123 merge failed.

@zz-jason
Copy link
Member

/run-integration-common-test

@zz-jason
Copy link
Member

/run-unit-test

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 30, 2020
@lzmhhh123 lzmhhh123 merged commit 1637c42 into pingcap:master Mar 30, 2020
@lzmhhh123 lzmhhh123 deleted the bug-fix/respect_tidb_snapshot branch March 30, 2020 14:37
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Mar 30, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

cherry pick to release-3.1 in PR #15872

@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

cherry pick to release-4.0 in PR #15873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants