Skip to content

distsql: fix wrong schema version when snapshot has been set (#15258)#15873

Merged
zz-jason merged 2 commits intopingcap:release-4.0from
sre-bot:release-4.0-1637c42d45db
Mar 30, 2020
Merged

distsql: fix wrong schema version when snapshot has been set (#15258)#15873
zz-jason merged 2 commits intopingcap:release-4.0from
sre-bot:release-4.0-1637c42d45db

Conversation

@sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 30, 2020

cherry-pick #15258 to release-4.0


What problem does this PR solve?

As the title says.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch (release-3.1

@sre-bot sre-bot requested a review from a team as a code owner March 30, 2020 14:44
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 30, 2020

/run-all-tests

@sre-bot sre-bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution priority/release-blocker This issue blocks a release. Please solve it ASAP. type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels Mar 30, 2020
@ghost ghost requested a review from SunRunAway March 30, 2020 14:44
@sre-bot sre-bot requested review from wshwsh12 and zimulala March 30, 2020 14:44
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2020
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 30, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 30, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 30, 2020

@sre-bot merge failed.

@zz-jason zz-jason merged commit d570ccf into pingcap:release-4.0 Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants