use absolute path for sed on mac#142
Merged
ngaut merged 1 commit intopingcap:masterfrom Sep 14, 2015
kwo:master
Merged
Conversation
Member
|
LGTM. Thanks |
Member
|
LGTM |
ngaut
added a commit
that referenced
this pull request
Sep 14, 2015
use absolute path for sed on mac
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
…ingcap#142) Currently, cleanup script in integration test does not work, if the developer wants to re-run integration test in his/her local environment, he/she has to clean /tmp/lightning_test_result manually
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
…ord arguments (pingcap#142) * ast,parser: added several expression types to represent keyword arguments Added TimeUnitExpr to represent time and timestamp units like SECOND in DATE_ADD(time, INTERVAL x SECOND). Added GetFormatSelectorExpr to represent the selectors like DATETIME in GET_FORMAT(DATETIME, locale). Added TrimDirectionExpr to represent the direction like BOTH in TRIM(BOTH 'x' FROM 'xyz'). Changed FrameBound's Unit to use TimeUnitType directly. Previously these were all converted into a string or integer ValueExpr, which made Restore() implementation very ugly. * ast: change type of PartitionMethod.Unit from ValueExpr to TimeUnitType
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
…ord arguments (pingcap#142) * ast,parser: added several expression types to represent keyword arguments Added TimeUnitExpr to represent time and timestamp units like SECOND in DATE_ADD(time, INTERVAL x SECOND). Added GetFormatSelectorExpr to represent the selectors like DATETIME in GET_FORMAT(DATETIME, locale). Added TrimDirectionExpr to represent the direction like BOTH in TRIM(BOTH 'x' FROM 'xyz'). Changed FrameBound's Unit to use TimeUnitType directly. Previously these were all converted into a string or integer ValueExpr, which made Restore() implementation very ugly. * ast: change type of PartitionMethod.Unit from ValueExpr to TimeUnitType
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
…ord arguments (#142) * ast,parser: added several expression types to represent keyword arguments Added TimeUnitExpr to represent time and timestamp units like SECOND in DATE_ADD(time, INTERVAL x SECOND). Added GetFormatSelectorExpr to represent the selectors like DATETIME in GET_FORMAT(DATETIME, locale). Added TrimDirectionExpr to represent the direction like BOTH in TRIM(BOTH 'x' FROM 'xyz'). Changed FrameBound's Unit to use TimeUnitType directly. Previously these were all converted into a string or integer ValueExpr, which made Restore() implementation very ugly. * ast: change type of PartitionMethod.Unit from ValueExpr to TimeUnitType
okJiang
pushed a commit
to okJiang/tidb
that referenced
this pull request
Oct 19, 2021
…ingcap#142) * reduce bound address times to save more time * tmp * unify file size * fix ut * fix bug that escapeBackSlash not used for rows arguments * tmp * move filesize and statementsize argument to writepipe * fix format * address comment
nolouch
pushed a commit
to tidblabs/tidb
that referenced
this pull request
Jan 6, 2023
…ase 6.4` rate limit (pingcap#155) * merge pr#130,pingcap#133 into 6.4 Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * fix start limit rate Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * default config Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * keyspace: use `user_storage_size` instead of `storage_size` for ratelimit (pingcap#145) * use user_storage_size instead of storage_size for ratelimit Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * update golang.org/x/text to 0.3.8 Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * Fix error handle when loadKeyspace failed at startup (pingcap#143) Signed-off-by: yongman <yming0221@gmail.com> Signed-off-by: yongman <yming0221@gmail.com> * add keyspace-activate mode (pingcap#142) * fix loadkeyspace nil (pingcap#144) * fix loadkeyspace nil Signed-off-by: ystaticy <y_static_y@sina.com> * retry load keyspace Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> * address comments Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> Signed-off-by: ystaticy <y_static_y@sina.com> Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> Co-authored-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> * Compatible with old pd Signed-off-by: zeminzhou <zhouzemin@pingcap.com> Signed-off-by: zeminzhou <zhouzemin@pingcap.com> Signed-off-by: yongman <yming0221@gmail.com> Signed-off-by: ystaticy <y_static_y@sina.com> Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> Co-authored-by: yongman <yming0221@gmail.com> Co-authored-by: better0332 <better0332@163.com> Co-authored-by: ystaticy <y_static_y@sina.com> Co-authored-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> * make check Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * fix confict Signed-off-by: zeminzhou <zhouzemin@pingcap.com> * make check Signed-off-by: zeminzhou <zhouzemin@pingcap.com> Signed-off-by: zeminzhou <zhouzemin@pingcap.com> Signed-off-by: yongman <yming0221@gmail.com> Signed-off-by: ystaticy <y_static_y@sina.com> Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> Co-authored-by: yongman <yming0221@gmail.com> Co-authored-by: better0332 <better0332@163.com> Co-authored-by: ystaticy <y_static_y@sina.com> Co-authored-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some developers might have gnu-sed installed installed in their path, so using the absolute path for the sed binary prevents an error.