Skip to content

add make command shell#130

Merged
ngaut merged 5 commits intopingcap:masterfrom
insionCEO:master
Sep 15, 2015
Merged

add make command shell#130
ngaut merged 5 commits intopingcap:masterfrom
insionCEO:master

Conversation

@insionCEO
Copy link

@insionCEO insionCEO commented Sep 13, 2015

No description provided.

insion added 2 commits September 13, 2015 11:28
just for windows
1a58d54 
make command
for linux/unix/osx
ade30aa 
make command
@ngaut
Copy link
Member

ngaut commented Sep 13, 2015

@qiuyesuifeng Please take a look.

@insionng Thank you, Could you sign the CLA. CI failed

@insionCEO
Copy link
Author

insionCEO commented Sep 13, 2015

okay~

@shenli
Copy link
Member

shenli commented Sep 13, 2015

@c4pt0r
Please take a look.

@qiuyesuifeng
Copy link
Member

qiuyesuifeng commented Sep 13, 2015

@insionng Thanks for your PR.

There are some additional things need to do:
1 For making tidb, u need do things as follows:
1.1 godep
godep is to get godep tool(https://github.com/tools/godep) which is used for easy building without getting dependency packages.

1.2 parser
parser is to get goyacc and golex package, generate parser/parser.go and parser/scanner.go which are needed by tidb building.
In your make.cmd, u have done this, but also need some work like in tidb/Makefile to generate parser/scanner.go：
golex -o parser/scanner.go parser/scanner.l

1.3 build
Godep go build

1.4 test
Godep go test ./...

2 For making interpreter, u need do things as follows:
2.1 add ldflags go build option[nice to haves]
LDFLAGS += -X "github.com/pingcap/tidb/util/printer.TiDBBuildTS=$(shell date -u '+%Y-%m-%d %I:%M:%S')"
LDFLAGS += -X "github.com/pingcap/tidb/util/printer.TiDBGitHash=$(shell git rev-parse HEAD)"
The ldflags is very useful for us to check and fix bugs.
The correct interpreter output looks like as follows:

Welcome to the TiDB.
Version:
Git Commit Hash: bf97f61c450912a5c1f4cfba44bb11297fa7876f
UTC Build Time:  20150913214037

tidb>

2.2 build
Godep go build -ldflags "-X github.com/pingcap/tidb/util/printer.TiDBBuildTS=%TiDBBuildTS% -X github.com/pingcap/tidb/util/printer.TiDBGitHash=%TiDBGitHash%"
TiDBBuildTS and TiDBGitHash variables are set in above 2.1

So u can see above, maybe some more work need to do in make.cmd.
And also, for unix/mac users, i think it is better to install make tool.
Thanks again, looking forward to your update :)

@insionCEO
Copy link
Author

insionCEO commented Sep 14, 2015

It has been updated.

@fuxiaohei fuxiaohei mentioned this pull request Sep 15, 2015
Closed
@ngaut
Copy link
Member

ngaut commented Sep 15, 2015

Well done. Looks like we don't need make.sh.
Just keep make.cmd is fine. We could still use make instead of make.sh.
Could you please remove make.sh. Then we will merge this PR.
Thanks. @insionng

@c4pt0r
Copy link
Member

c4pt0r commented Sep 15, 2015

LGTM

@ngaut
Copy link
Member

ngaut commented Sep 15, 2015

LGTM. Thank you @insionng

ngaut added a commit that referenced this pull request Sep 15, 2015
@ngaut
Merge pull request #130 from insionng/master
3bf5e14 
add make command shell
@ngaut ngaut merged commit 3bf5e14 into pingcap:master Sep 15, 2015
@rapoth rapoth mentioned this pull request Aug 23, 2017
Closed
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021
@zhouqiang-cl @kennytm
add code coverage badge and build status (pingcap#130)
870be6f 
* add badge

* replace build to test
xhebox pushed a commit to xhebox/tidb that referenced this pull request Sep 28, 2021
@SwanSpouse
[parser] parser: fix GroupByClause.Restore, and add keyword (pingcap#130
c022c37 
)
xhebox pushed a commit to xhebox/tidb that referenced this pull request Oct 8, 2021
@SwanSpouse @xhebox
[parser] parser: fix GroupByClause.Restore, and add keyword (pingcap#130
e08d865 
)
ti-chi-bot pushed a commit that referenced this pull request Oct 9, 2021
@SwanSpouse @ti-chi-bot
[parser] parser: fix GroupByClause.Restore, and add keyword (#130)
17e7f1d
okJiang pushed a commit to okJiang/tidb that referenced this pull request Oct 19, 2021
@lichunzhu
close connection after export (pingcap#130)
80896bf 
* close connection after export
nolouch pushed a commit to tidblabs/tidb that referenced this pull request Jan 6, 2023
@zeminzhou @yongman
@better0332 @ystaticy @AmoebaProtozoa
Merge PR pingcap#130, pingcap#133, pingcap#145 into `keyspace on rele…
e11f56c 
…ase 6.4` rate limit (pingcap#155)

* merge pr#130,pingcap#133 into 6.4

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* fix start limit rate

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* default config

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* keyspace: use `user_storage_size` instead of `storage_size` for ratelimit (pingcap#145)

* use user_storage_size instead of storage_size for ratelimit

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* update golang.org/x/text to 0.3.8

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* Fix error handle when loadKeyspace failed at startup (pingcap#143)

Signed-off-by: yongman <yming0221@gmail.com>

Signed-off-by: yongman <yming0221@gmail.com>

* add keyspace-activate mode (pingcap#142)

* fix loadkeyspace nil (pingcap#144)

* fix loadkeyspace nil

Signed-off-by: ystaticy <y_static_y@sina.com>

* retry load keyspace

Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>

* address comments

Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>

Signed-off-by: ystaticy <y_static_y@sina.com>
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Co-authored-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>

* Compatible with old pd

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: yongman <yming0221@gmail.com>
Signed-off-by: ystaticy <y_static_y@sina.com>
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Co-authored-by: yongman <yming0221@gmail.com>
Co-authored-by: better0332 <better0332@163.com>
Co-authored-by: ystaticy <y_static_y@sina.com>
Co-authored-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>

* make check

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* fix confict

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

* make check

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: yongman <yming0221@gmail.com>
Signed-off-by: ystaticy <y_static_y@sina.com>
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Co-authored-by: yongman <yming0221@gmail.com>
Co-authored-by: better0332 <better0332@163.com>
Co-authored-by: ystaticy <y_static_y@sina.com>
Co-authored-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

contribution This PR is from a community contributor.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@insionCEO @ngaut @shenli @qiuyesuifeng @c4pt0r @sre-bot