Skip to content

expression: implement vectorized evaluation for builtinSecondSig#12886

Merged
sre-bot merged 2 commits intopingcap:masterfrom
yangdong2398:master
Oct 23, 2019
Merged

expression: implement vectorized evaluation for builtinSecondSig#12886
sre-bot merged 2 commits intopingcap:masterfrom
yangdong2398:master

Conversation

@yangdong2398
Copy link
Contributor

@yangdong2398 yangdong2398 commented Oct 23, 2019

Implement builtinSecondSig

What problem does this PR solve?

Implement vec builtinSecondSig

What is changed and how it works?

BenchmarkVectorizedBuiltinTimeFunc/builtinSecondSig-VecBuiltinFunc-4 120044 10199 ns/op 0 B/op 0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinSecondSig-NonVecBuiltinFunc-4 31761 39806 ns/op 0 B/op 0 allocs/op

Check List

Tests

  • Unit test

Implement builtinSecondSig
@yangdong2398 yangdong2398 requested a review from a team as a code owner October 23, 2019 02:04
@ghost ghost requested a review from wshwsh12 October 23, 2019 02:04
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 23, 2019
@ghost ghost removed their request for review October 23, 2019 02:04
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #12886 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12886   +/-   ##
===========================================
  Coverage   79.9737%   79.9737%           
===========================================
  Files           465        465           
  Lines        107604     107604           
===========================================
  Hits          86055      86055           
  Misses        15063      15063           
  Partials       6486       6486

@wshwsh12 wshwsh12 requested a review from qw4990 October 23, 2019 02:54
@qw4990 qw4990 changed the title Update builtin_time_vec.go expression: implement vectorized evaluation for builtinSecondSig Oct 23, 2019
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 23, 2019
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 23, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 23, 2019

/run-all-tests

@sre-bot sre-bot merged commit b1ca985 into pingcap:master Oct 23, 2019
lfkdsk added a commit to JustProject/tidb that referenced this pull request Oct 26, 2019
…ect/tidb into feature-add-udf-support

* 'feature-add-udf-support' of https://github.com/JustProject/tidb: (26 commits)
  *: fix bug that the kill command doesn't work when the killed session is waiting for the pessimistic lock (pingcap#12852)
  executor: fix the projection upon the indexLookUp in indexLookUpJoin can't get result. (pingcap#12889)
  planner, executor: support create view on union (pingcap#12595)
  planner/cascades: introduce TransformationID in cascades planner (pingcap#12879)
  executor: fix data race in test (pingcap#12910)
  executor: reuse chunk row for insert on duplicate update (pingcap#12847)
  ddl: speed up tests (pingcap#12888)
  executor: speed up test (pingcap#12896)
  expression: implement vectorized evaluation for `builtinSecondSig` (pingcap#12886)
  expression: implement vectorized evaluation for `builtinJSONObjectSig` (pingcap#12663)
  expression: speed up builtinRepeatSig by using MergeNulls (pingcap#12674)
  expression: speed up unit tests under the expression package (pingcap#12887)
  store,kv: snapshot doesn't cache the non-exists kv entries lead to poor 'insert ignore' performance (pingcap#12872)
  executor: fix data race in `GetDirtyTable()` (pingcap#12767)
  domain: increase TTL to reduce the occurrence of reporting min startTS errors (pingcap#12578)
  executor: split test for speed up (pingcap#12881)
  executor: fix inconsistent of grants privileges with MySQL when executing `grant all on ...` (pingcap#12330)
  expression: implement vectorized evaluation for `builtinJSONUnquoteSig` (pingcap#12841)
  tune grpc connection count between tidb and tikv (pingcap#12884)
  Makefile: change test parallel to 8 (pingcap#12885)
  ...
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants