executor: fix inconsistent of grants privileges with MySQL when executing `grant all on ...` by tsthght · Pull Request #12330 · pingcap/tidb

tsthght · 2019-09-24T03:30:49Z

What problem does this PR solve?

1 fix bug for #12324
2 fix bug for execute SQL show grants for xxx

What is changed and how it works?

create user "ght1";
grant all on . to 'ght1'@'%' identified by 'Poiuy123';
select * from mysql.user where user='ght1'\G
*************************** 1. row ***************************
Grant_priv: N

Check List

Tests

Unit test

imtbkcat · 2019-09-24T06:09:22Z

@tsthght Please fix test below:

privileges_test.go:265
privileges_test.go:504
privileges_test.go:694

And add some test to test GRANT ALL and GRANT ... WITH GRANT OPTION

codecov · 2019-09-24T12:54:26Z

Codecov Report

Merging #12330 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12330   +/-   ##
===========================================
  Coverage   80.0356%   80.0356%           
===========================================
  Files           465        465           
  Lines        107136     107136           
===========================================
  Hits          85747      85747           
  Misses        14951      14951           
  Partials       6438       6438

tsthght · 2019-09-24T23:58:29Z

/rebuild

imtbkcat · 2019-09-25T02:56:24Z

/run-unit-test

executor/grant.go

tiancaiamao · 2019-10-16T02:49:02Z

Any update? @tsthght

tsthght · 2019-10-16T02:53:00Z

Any update? @tsthght

It will be updated today.

privilege/privileges/privileges_test.go

tiancaiamao · 2019-10-17T08:16:54Z

You can use go mod edit github.com/pingcap/parser=github.com/tsthght/parser@pri to use the right parser version. @tsthght

tsthght · 2019-10-17T08:20:16Z

You can use go mod edit github.com/pingcap/parser=github.com/tsthght/parser@pri to use the right parser version. @tsthght

Great! Thank you, I will try it~

go.mod

tiancaiamao · 2019-10-22T06:50:05Z

/run-all-tests

tiancaiamao · 2019-10-22T06:53:57Z

/run-all-tests

imtbkcat · 2019-10-22T08:27:22Z

/run-integration-common-test tidb-test=pr/926

imtbkcat · 2019-10-22T08:35:34Z

/run-all-tests tidb-test=pr/926

tsthght · 2019-10-22T09:05:05Z

/run-all-tests

imtbkcat · 2019-10-22T09:21:40Z

/run-all-tests tidb-test=pr/926

imtbkcat · 2019-10-22T09:57:35Z

I will approve after test merge, wait a moment.

tiancaiamao · 2019-10-22T12:42:21Z

LGTM

imtbkcat · 2019-10-23T03:27:30Z

/run-all-tests tidb-test=pr/926

imtbkcat

LGTM

…ect/tidb into feature-add-udf-support * 'feature-add-udf-support' of https://github.com/JustProject/tidb: (26 commits) *: fix bug that the kill command doesn't work when the killed session is waiting for the pessimistic lock (pingcap#12852) executor: fix the projection upon the indexLookUp in indexLookUpJoin can't get result. (pingcap#12889) planner, executor: support create view on union (pingcap#12595) planner/cascades: introduce TransformationID in cascades planner (pingcap#12879) executor: fix data race in test (pingcap#12910) executor: reuse chunk row for insert on duplicate update (pingcap#12847) ddl: speed up tests (pingcap#12888) executor: speed up test (pingcap#12896) expression: implement vectorized evaluation for `builtinSecondSig` (pingcap#12886) expression: implement vectorized evaluation for `builtinJSONObjectSig` (pingcap#12663) expression: speed up builtinRepeatSig by using MergeNulls (pingcap#12674) expression: speed up unit tests under the expression package (pingcap#12887) store,kv: snapshot doesn't cache the non-exists kv entries lead to poor 'insert ignore' performance (pingcap#12872) executor: fix data race in `GetDirtyTable()` (pingcap#12767) domain: increase TTL to reduce the occurrence of reporting min startTS errors (pingcap#12578) executor: split test for speed up (pingcap#12881) executor: fix inconsistent of grants privileges with MySQL when executing `grant all on ...` (pingcap#12330) expression: implement vectorized evaluation for `builtinJSONUnquoteSig` (pingcap#12841) tune grpc connection count between tidb and tikv (pingcap#12884) Makefile: change test parallel to 8 (pingcap#12885) ...

…ting `grant all on ...` (pingcap#12330)

…ting `grant all on ...` (#12330) (#13943)

…ting `grant all on ...` (pingcap#12330)

fix bug #12324

e5887dc

sre-bot added the contribution This PR is from a community contributor. label Sep 24, 2019

jackysp requested review from imtbkcat and tiancaiamao September 24, 2019 04:30

tsthght changed the title ~~fix bug #12324~~ executor: fix inconsistent of grants privileges with MySQL when executing grant all on ... Sep 24, 2019

zz-jason added component/privilege type/bugfix This PR fixes a bug. labels Sep 24, 2019

Hokkaitao and others added 5 commits September 24, 2019 17:09

fix inconsistent with mysql when execute

ef5c4a8

add some testcase

ee12808

fix Unit test

89191e6

fix Unit tests

fa68820

Merge branch 'master' into pri

d0e0df2

Merge branch 'master' into pri

5b6db8c

Merge branch 'master' into pri

9d5b207

imtbkcat reviewed Sep 25, 2019

View reviewed changes

executor/grant.go Outdated Show resolved Hide resolved

tsthght mentioned this pull request Oct 17, 2019

remove GrantPriv from AllGlobalPrivs/AllDBPrivs/AllTablePrivs pingcap/parser#581

Merged

tsthght added 2 commits October 17, 2019 09:27

modify

d0a4792

fix testcase error

4b6cbab

tiancaiamao reviewed Oct 17, 2019

View reviewed changes

privilege/privileges/privileges_test.go Show resolved Hide resolved

privilege/privileges/privileges_test.go Show resolved Hide resolved

tsthght added 2 commits October 17, 2019 17:21

modify go.mod

6babea2

add more testcase

0d7f32d

tiancaiamao reviewed Oct 18, 2019

View reviewed changes

go.mod Outdated Show resolved Hide resolved

Merge branch 'master' into pri & fix CI

d5e6bd7

go mod tidy

7c0a495

Lingyu Song and others added 5 commits October 22, 2019 15:27

Merge branch 'master' into pri

cc8e6d2

Merge branch 'master' into pri

bb4bda3

fix error

e55a1aa

Merge branch 'pri' of https://github.com/tsthght/tidb into pri

ea9ae9e

Merge branch 'master' into pri

2f34fbc

Merge branch 'master' into pri

ea0140f

Merge branch 'master' into pri

1150b09

tsthght and others added 2 commits October 23, 2019 10:15

Merge branch 'master' into pri

b448ce7

Merge branch 'master' into pri

5405625

zz-jason requested a review from imtbkcat October 23, 2019 03:20

imtbkcat approved these changes Oct 23, 2019

View reviewed changes

imtbkcat added the status/all tests passed label Oct 23, 2019

imtbkcat merged commit 9a074ca into pingcap:master Oct 23, 2019

imtbkcat mentioned this pull request Dec 6, 2019

executor: fix inconsistent of grants privileges with MySQL when executing grant all on ... (#12330) #13943

Merged

imtbkcat pushed a commit to imtbkcat/tidb that referenced this pull request Dec 9, 2019

executor: fix inconsistent of grants privileges with MySQL when execu…

3c123b3

…ting `grant all on ...` (pingcap#12330)

sre-bot pushed a commit that referenced this pull request Dec 9, 2019

executor: fix inconsistent of grants privileges with MySQL when execu…

e4bcdd4

…ting `grant all on ...` (#12330) (#13943)

XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019

executor: fix inconsistent of grants privileges with MySQL when execu…

ddd028b

…ting `grant all on ...` (pingcap#12330)

Conversation

tsthght commented Sep 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Uh oh!

imtbkcat commented Sep 24, 2019

Uh oh!

codecov bot commented Sep 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tsthght commented Sep 24, 2019

Uh oh!

imtbkcat commented Sep 25, 2019

Uh oh!

Uh oh!

tiancaiamao commented Oct 16, 2019

Uh oh!

tsthght commented Oct 16, 2019

Uh oh!

Uh oh!

Uh oh!

tiancaiamao commented Oct 17, 2019

Uh oh!

tsthght commented Oct 17, 2019

Uh oh!

Uh oh!

tiancaiamao commented Oct 22, 2019

Uh oh!

tiancaiamao commented Oct 22, 2019

Uh oh!

imtbkcat commented Oct 22, 2019

Uh oh!

imtbkcat commented Oct 22, 2019

Uh oh!

tsthght commented Oct 22, 2019

Uh oh!

imtbkcat commented Oct 22, 2019

Uh oh!

imtbkcat commented Oct 22, 2019

Uh oh!

tiancaiamao commented Oct 22, 2019

Uh oh!

imtbkcat commented Oct 23, 2019

Uh oh!

imtbkcat left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tsthght commented Sep 24, 2019 •

edited

Loading

codecov bot commented Sep 24, 2019 •

edited

Loading