expression: implement vectorized evaluation for builtinCastTimeAsDecimalSig#12426
Merged
sre-bot merged 2 commits intopingcap:masterfrom Sep 27, 2019
Merged
Conversation
Contributor
Author
|
/run-unit-test |
Member
|
@polyrabbit thanks for your contribution, please follow the Commit Message and Pull Request Style guide to reformat the PR title. |
Contributor
Author
|
As said in #12421 , how does the new title look like? |
Member
|
@polyrabbit |
Contributor
Author
|
@francis0407 OK, modified |
Contributor
|
/run-all-tests |
polyrabbit
added a commit
to polyrabbit/tidb
that referenced
this pull request
Sep 27, 2019
…meAsDecimalSig (pingcap#12426)" This reverts commit ae723ec.
SunRunAway
reviewed
Sep 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement vectorized evaluation for
builtinCastTimeAsRealSig, as listed in #12105.What is changed and how it works?
According to benchmark, this change improves the performance, but not too much.
$ go test -v -benchmem -bench=BenchmarkVectorizedBuiltinCastFunc -run=BenchmarkVectorizedBuiltinCastFunc goos: darwin goarch: amd64 pkg: github.com/pingcap/tidb/expression ... BenchmarkVectorizedBuiltinCastFunc/builtinCastTimeAsDecimalSig-VecBuiltinFunc-8 3000 494479 ns/op 155393 B/op 8829 allocs/op BenchmarkVectorizedBuiltinCastFunc/builtinCastTimeAsDecimalSig-NonVecBuiltinFunc-8 3000 545625 ns/op 155393 B/op 8829 allocs/opCheck List
Tests