expression: implement vectorized evaluation for builtinCastTimeAsRealSig#12421
Merged
ngaut merged 3 commits intopingcap:masterfrom Sep 27, 2019
Merged
expression: implement vectorized evaluation for builtinCastTimeAsRealSig#12421ngaut merged 3 commits intopingcap:masterfrom
ngaut merged 3 commits intopingcap:masterfrom
Conversation
|
|
Member
|
@polyrabbit thanks for your contribution, please follow the Commit Message and Pull Request Style guide to reformat the PR title. |
Contributor
Author
|
Ah, I missed the rule. How does the new title look like? |
Contributor
|
/run-all-tests |
Contributor
|
@polyrabbit merge failed. |
Contributor
|
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #12421 +/- ##
===========================================
Coverage 79.7522% 79.7522%
===========================================
Files 462 462
Lines 102125 102125
===========================================
Hits 81447 81447
Misses 14811 14811
Partials 5867 5867 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement vectorized evaluation for
builtinCastTimeAsRealSig, as listed in #12105.What is changed and how it works?
According to benchmark, this change improves the performance, but not too much.
$ go test -v -benchmem -bench=BenchmarkVectorizedBuiltinCastFunc -run=BenchmarkVectorizedBuiltinCastFunc ... BenchmarkVectorizedBuiltinCastFunc/builtinCastTimeAsRealSig-VecBuiltinFunc-8 2000 651840 ns/op 193505 B/op 10298 allocs/op BenchmarkVectorizedBuiltinCastFunc/builtinCastTimeAsRealSig-NonVecBuiltinFunc-8 2000 700970 ns/op 193505 B/op 10298 allocs/opCheck List
Tests