*: refactoring the code of batchChecker#12108
Merged
tiancaiamao merged 5 commits intopingcap:masterfrom Sep 10, 2019
Merged
Conversation
batchChecker is difficult to maintain, we should get rid of it. In this commit I catch the BatchGet result into the snapshot, in this way we can achieve the same goal as the batchChecker
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #12108 +/- ##
===========================================
Coverage 81.5473% 81.5473%
===========================================
Files 449 449
Lines 97124 97124
===========================================
Hits 79202 79202
Misses 12317 12317
Partials 5605 5605 |
jackysp
reviewed
Sep 10, 2019
Contributor
|
/run-all-tests |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/rebuild |
lysu
reviewed
Sep 10, 2019
Contributor
lysu
left a comment
There was a problem hiding this comment.
LGTM, so update, replace also need do same thing?
Contributor
Author
|
Yes, if we want to remove the batchChecker totally. @lysu |
Contributor
Author
|
/run-all-tests |
Contributor
|
cherry pick to release-3.0 failed |
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Sep 10, 2019
Contributor
|
It seems that, not for sure, we failed to cherry-pick this commit to release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @tiancaiamao PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The
batchCheckeris difficult to maintain, we should try to get rid of it.Expect:
Get:
What is changed and how it works?
The first step: do not use it.
The second step: clean up the code.
In this commit, I catch the BatchGet result into the snapshot, in this way we can achieve the same goal as the
batchCheckerI re-implement the
insert ... on duplicate key update ...without using thebatchChecker.Check List
Tests
Side effects
Related changes
Release note
Fix bugs of
insert ... on duplicate updateon the partitioned table