Skip to content

*: refactoring the code of batchChecker #12108#12141

Merged
sre-bot merged 7 commits intopingcap:release-3.0from
tiancaiamao:cherry-pick-3.0
Sep 12, 2019
Merged

*: refactoring the code of batchChecker #12108#12141
sre-bot merged 7 commits intopingcap:release-3.0from
tiancaiamao:cherry-pick-3.0

Conversation

@tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Sep 10, 2019

Cherry-pick #12108
Cherrp-pick #12147

PTAL @jackysp @lysu @imtbkcat

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

@tiancaiamao should we also cherry pick it to release 3.1?

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 12, 2019
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 12, 2019
@tiancaiamao
Copy link
Contributor Author

OK, I'll cherry-pick this one after it's merged.

@lysu lysu added the status/can-merge Indicates a PR has been approved by a committer. label Sep 12, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 12, 2019

Sorry @lysu, you don't have permission to trigger auto merge event on this branch.

Copy link
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Contributor

jackysp commented Sep 12, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Sep 12, 2019

/run-all-tests

@sre-bot sre-bot merged commit ff955ac into pingcap:release-3.0 Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants