types: Update FieldType.Equal safety.#841
Merged
kennytm merged 2 commits intopingcap:masterfrom Apr 30, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #841 +/- ##
==========================================
+ Coverage 78.18% 78.28% +0.09%
==========================================
Files 40 40
Lines 14638 14638
==========================================
+ Hits 11445 11459 +14
+ Misses 2512 2497 -15
- Partials 681 682 +1 |
kennytm
reviewed
Apr 28, 2020
Contributor
kennytm
left a comment
There was a problem hiding this comment.
Please add a unit test for these equality rules.
31228ba to
e270d79
Compare
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
* Fix float flen free bug. * Add unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
This pr is a subsequent modification of parser/pull/832.
We find that when
Decimalis specified,Flenwill have a specific effect, see floating-point-types.Current judgments can also cause problems.
This pr fixes it.
Check List
Tests
Code changes