types: Don't check Flen when Tp is double or float in FieldType.Equal.#832
Merged
LittleFall merged 3 commits intopingcap:masterfrom Apr 26, 2020
Merged
types: Don't check Flen when Tp is double or float in FieldType.Equal.#832LittleFall merged 3 commits intopingcap:masterfrom
Flen when Tp is double or float in FieldType.Equal.#832LittleFall merged 3 commits intopingcap:masterfrom
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #832 +/- ##
=======================================
Coverage 78.35% 78.35%
=======================================
Files 40 40
Lines 14755 14755
=======================================
Hits 11562 11562
Misses 2512 2512
Partials 681 681 |
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
…Equal`. (pingcap#832) * float flen free. * Fix bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Don't check
FlenwhenTpis double or float inFieldType.Equal, becauseFlenfor them is only used to distinguish float and double.Check List
Tests
make testeven formasteris failed)Code changes