support CREATE VIEW ... UnionStmt#572
Merged
XuHuaiyu merged 6 commits intopingcap:masterfrom Oct 11, 2019
Merged
Conversation
4c3813c to
e23be0f
Compare
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
=======================================
Coverage 71.77% 71.77%
=======================================
Files 32 32
Lines 7820 7820
=======================================
Hits 5613 5613
Misses 1676 1676
Partials 531 531
Continue to review full report at Codecov.
|
wshwsh12
reviewed
Oct 10, 2019
Contributor
There was a problem hiding this comment.
mysql 8.0> create view v as (select * from t union select * from t);
Query OK, 0 rows affected (0.00 sec)
tidb> create view v as (select * from t union select * from t);
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your TiDB version for the right syntax to use line 1 column 39 near "union select * from t)"
I think that create view on (union) syntax should be supported, too.
kennytm
reviewed
Oct 11, 2019
XuHuaiyu
added a commit
to XuHuaiyu/parser
that referenced
this pull request
Oct 11, 2019
XuHuaiyu
added a commit
to XuHuaiyu/parser
that referenced
this pull request
Oct 11, 2019
This was referenced Oct 11, 2019
kennytm
pushed a commit
that referenced
this pull request
Oct 11, 2019
kennytm
pushed a commit
that referenced
this pull request
Oct 11, 2019
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Before this:
What is changed and how it works?
After this, create view on
unionand create view on(select)syntax are supported.Check List
Tests
Code changes
Side effects
N/A
Related changes