Skip to content

support CREATE VIEW ... UnionStmt (#572)#573

Merged
kennytm merged 1 commit intopingcap:release-3.1from
XuHuaiyu:release-3.1
Oct 11, 2019
Merged

support CREATE VIEW ... UnionStmt (#572)#573
kennytm merged 1 commit intopingcap:release-3.1from
XuHuaiyu:release-3.1

Conversation

@XuHuaiyu
Copy link
Contributor

cherry-pick #572

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release-3.1@a90dba5). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-3.1     #573   +/-   ##
==============================================
  Coverage               ?   51.27%           
==============================================
  Files                  ?       31           
  Lines                  ?     6888           
  Branches               ?        0           
==============================================
  Hits                   ?     3532           
  Misses                 ?     3006           
  Partials               ?      350
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø)
ast/ddl.go 44.47% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a90dba5...2813e1f. Read the comment docs.

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT2 LGT2 and removed type/bug Something isn't working labels Oct 11, 2019
@kennytm kennytm merged commit 0c4055e into pingcap:release-3.1 Oct 11, 2019
@XuHuaiyu XuHuaiyu deleted the release-3.1 branch October 17, 2019 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants