This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Update PD and adapt new PD client APIs#447
Merged
3pointer merged 3 commits intopingcap:masterfrom Aug 5, 2020
Merged
Conversation
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
|
|
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-integration-tests |
1 similar comment
Collaborator
|
/run-integration-tests |
Member
|
LGTM |
ti-srebot
approved these changes
Aug 5, 2020
Contributor
|
cherry pick to release-4.0 failed |
Contributor
Author
|
@3pointer Need we cherry pick it to 4.0？The corresponding PD change is not cherry picked to 4.0 tikv/pd#2649 |
3pointer
pushed a commit
to 3pointer/br
that referenced
this pull request
Oct 16, 2020
* update pd and related dependencies Signed-off-by: Yilin Chen <sticnarf@gmail.com> * update tidb to master Signed-off-by: Yilin Chen <sticnarf@gmail.com> Co-authored-by: kennytm <kennytm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
New PD client changes the API of
ScanRegions. TiDB and BR won't compile with new PD.To make TiDB compile, TiDB is now using a non-master branch of br (https://github.com/pingcap/br/tree/update-pd-20200803). In that branch, some changes are done to adapt new PD client APIs. This PR intends to merge it to master.
Check List
Tests
Release Note
No release note.