Skip to content

*: include down/pending peers in ScanRegions response#2649

Merged
ti-srebot merged 4 commits intotikv:masterfrom
oh-my-tidb:pending-down-peers
Jul 15, 2020
Merged

*: include down/pending peers in ScanRegions response#2649
ti-srebot merged 4 commits intotikv:masterfrom
oh-my-tidb:pending-down-peers

Conversation

@disksing
Copy link
Contributor

What problem does this PR solve?

TiDB needs to know down/pending peers of a region. Currently, we only provide the information in GetRegion but not ScanRegions.

What is changed and how it works?

Add them in ScanRegions response.

Check List

Tests

  • Unit test

Release note

  • No release note

disksing added 2 commits July 15, 2020 12:10
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the component/client Client logic. label Jul 15, 2020
@disksing disksing requested review from JmPotato, Yisaer and rleungx July 15, 2020 05:38
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2020
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@JmPotato,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: scheduling(slack).

@disksing disksing added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 15, 2020
@disksing
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 2650

@ti-srebot
Copy link
Contributor

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/client Client logic. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants