This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Conversation
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
=======================================
Coverage 70.28% 70.28%
=======================================
Files 48 48
Lines 4786 4786
=======================================
Hits 3364 3364
Misses 976 976
Partials 446 446 Continue to review full report at Codecov.
|
kennytm
reviewed
Apr 21, 2020
Collaborator
kennytm
left a comment
There was a problem hiding this comment.
This will break if the filter is set to case-sensitive. Please wait for the fix of the filter package instead.
Collaborator
Author
|
/run-all-tests |
1 similar comment
Collaborator
Author
|
/run-all-tests |
Collaborator
|
LGTM |
3pointer
added a commit
to 3pointer/br
that referenced
this pull request
Apr 23, 2020
* restore: use lower string to filter since we use lower string to filter backup Co-authored-by: kennytm <kennytm@gmail.com>
kennytm
added a commit
that referenced
this pull request
Apr 24, 2020
* Restore with lower case (#240) * restore: use lower string to filter since we use lower string to filter backup Co-authored-by: kennytm <kennytm@gmail.com> * tools: replace retool by GO111MODULE (#244) * tools: replace retool by GO111MODULE * Makefile: temporarily shut up golangci-lint Co-authored-by: kennytm <kennytm@gmail.com>
3pointer
added a commit
to 3pointer/br
that referenced
this pull request
Apr 26, 2020
* restore: use lower string to filter since we use lower string to filter backup Co-authored-by: kennytm <kennytm@gmail.com>
3pointer
added a commit
that referenced
this pull request
Apr 26, 2020
* backup: generate backupmeta when backup empty. (#235) * cmd: don't use ':' in the default log file name (#236) * Update build status badge (#239) * tools: replace retool by GO111MODULE (#244) * tools: replace retool by GO111MODULE * Makefile: temporarily shut up golangci-lint * Restore with lower case (#240) * restore: use lower string to filter since we use lower string to filter backup Co-authored-by: kennytm <kennytm@gmail.com> * storage: support placing the S3/GCS options into the storage URL (#246) * Rebase auto random counter after restore (#248) * *: support auto random backup & restore * update release 3.1 Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com> Co-authored-by: kennytm <kennytm@gmail.com> Co-authored-by: Neil Shen <overvenus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix the issue that BR not support restore table with Upper table name.
What is changed and how it works?
add integration test for Upper table name.
Check List
Tests
Related changes