Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Restore with lower case (#240)#245

Merged
kennytm merged 2 commits intopingcap:release-4.0from
3pointer:release-4.0
Apr 24, 2020
Merged

Restore with lower case (#240)#245
kennytm merged 2 commits intopingcap:release-4.0from
3pointer:release-4.0

Conversation

@3pointer
Copy link
Collaborator

cherry-pick #240 to release-4.0

What problem does this PR solve?

fix the issue that BR not support restore table with Upper table name.

What is changed and how it works?

add integration test for Upper table name.

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch

3pointer and others added 2 commits April 23, 2020 20:04
* restore: use lower string to filter since we use lower string to filter backup


Co-authored-by: kennytm <kennytm@gmail.com>
* tools: replace retool by GO111MODULE

* Makefile: temporarily shut up golangci-lint
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #245 into release-4.0 will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0     #245      +/-   ##
===============================================
+ Coverage        70.34%   70.37%   +0.02%     
===============================================
  Files               47       47              
  Lines             4671     4705      +34     
===============================================
+ Hits              3286     3311      +25     
- Misses             949      954       +5     
- Partials           436      440       +4     
Impacted Files Coverage Δ
main.go 77.14% <0.00%> (-22.86%) ⬇️
pkg/restore/import.go 66.66% <0.00%> (-4.02%) ⬇️
pkg/restore/split_client.go 50.48% <0.00%> (-0.98%) ⬇️
pkg/backup/client.go 72.96% <0.00%> (+2.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 194a4ff...3577c64. Read the comment docs.

@kennytm kennytm added the status/LGT1 LGTM1 label Apr 23, 2020
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@overvenus overvenus added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Apr 24, 2020
@kennytm kennytm merged commit 69444ab into pingcap:release-4.0 Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants