Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

pkg: use the GoTimeToTS() from oracle pkg#1139

Merged
ti-chi-bot merged 1 commit intopingcap:masterfrom
JmPotato:fix_GoTimeToTS
May 24, 2021
Merged

pkg: use the GoTimeToTS() from oracle pkg#1139
ti-chi-bot merged 1 commit intopingcap:masterfrom
JmPotato:fix_GoTimeToTS

Conversation

@JmPotato
Copy link
Member

@JmPotato JmPotato commented May 24, 2021 •
edited
Loading

Signed-off-by: JmPotato ghzpotato@gmail.com

What problem does this PR solve?

GoTimeToTS() from varsutil.go#L469 is exactly the same as GoTimeToTS() in oracle pkg which is the original version and the right place it should belong to.

What is changed and how it works?

Use oracle.GoTimeToTS() instead of variable.GoTimeToTS(), and the latter will be removed in pingcap/tidb#24813.

Check List

Tests

  • Unit test
  • Integration test

Related changes

Release note

  • No release note.

@JmPotato
Use the GoTimeToTS() from oracle pkg
990f3f9 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot requested review from 3pointer and kennytm May 24, 2021 05:25
Yisaer
Yisaer approved these changes May 24, 2021
View reviewed changes
Copy link

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 24, 2021

@Yisaer: Thanks for your review. The bot only counts /lgtm from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JmPotato JmPotato mentioned this pull request May 24, 2021
Merged
@kennytm
Copy link
Collaborator

kennytm commented May 24, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label May 24, 2021
Little-Wallace
Little-Wallace approved these changes May 24, 2021
View reviewed changes
Copy link
Collaborator

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 24, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Little-Wallace
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels May 24, 2021
@JmPotato
Copy link
Member Author

JmPotato commented May 24, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 24, 2021

@JmPotato: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Little-Wallace
Copy link
Collaborator

Little-Wallace commented May 24, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 24, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 990f3f9

@purelind
Copy link

purelind commented May 24, 2021

/run-integration-test

1 similar comment
@JmPotato
Copy link
Member Author

JmPotato commented May 24, 2021

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit 58e9e24 into pingcap:master May 24, 2021
@JmPotato JmPotato deleted the fix_GoTimeToTS branch May 24, 2021 08:37
3pointer pushed a commit to 3pointer/br that referenced this pull request Jun 4, 2021
@JmPotato @3pointer
pkg: use the GoTimeToTS() from oracle pkg (pingcap#1139)
3f550b1
3pointer pushed a commit to 3pointer/br that referenced this pull request Jun 4, 2021
@JmPotato @3pointer
pkg: use the GoTimeToTS() from oracle pkg (pingcap#1139)
bb8eaad
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@3pointer 3pointer Awaiting requested review from 3pointer

@kennytm kennytm Awaiting requested review from kennytm

2 more reviewers

@Yisaer Yisaer Yisaer approved these changes

@Little-Wallace Little-Wallace Little-Wallace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XS status/can-merge status/LGT2 LGTM2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JmPotato @ti-chi-bot @kennytm @Little-Wallace @purelind @Yisaer