*: clean up the deserted syntax of START TRANSACTION READ ONLY#24813
Merged
ti-chi-bot merged 13 commits intopingcap:masterfrom May 25, 2021
Merged
*: clean up the deserted syntax of START TRANSACTION READ ONLY#24813ti-chi-bot merged 13 commits intopingcap:masterfrom
ti-chi-bot merged 13 commits intopingcap:masterfrom
Conversation
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Member
Author
Signed-off-by: JmPotato <ghzpotato@gmail.com>
…transaction_executor
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Member
Author
|
CI tests will pass after pingcap/br#1139 is merged. |
…transaction_executor
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Member
Author
|
/run-all-tests |
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Contributor
|
/lgtm |
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by writing |
Contributor
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 6c41d3e |
Member
Author
|
/run-e2e-test |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JmPotato ghzpotato@gmail.com
What problem does this PR solve?
Issue Number: close #24291.
Problem Summary: After supporting the
AS OF TIMESTAMPsyntax forSTART TRANSACTION READ ONLYstatement, we need to clean up the remaining deserted syntax.What is changed and how it works?
sessionctx.StalenessTxnOptionsince we don't need it anymore.NewTxnWithStalenessOptiontoNewTxnWithStartTS.StartTSOption.Check List
Tests
Release note
No release note.