Conversation
…output and alternative path verification
…tect workflows branch
…ically determine workflows repository branch
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a Symfony 6 freeze mechanism for specific repository branches to control Symfony version constraints during CI workflows. The implementation adds a centralized configuration file and integrates version constraint logic into existing GitHub Actions workflows.
Key changes:
- Adds a JSON configuration file to define which repository branches should use frozen Symfony 6 versions
- Implements branch detection and configuration download steps in CI workflows to conditionally require symfony-freeze package
- Enhances logging output in test workflows for better debugging and traceability
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| config/symfony6-freeze.json | Defines portal-engine branches (5.1, 5.0) that should use Symfony 6 freeze |
| .github/workflows/reusable-static-analysis-centralized.yaml | Adds logic to detect target branch, download freeze config, and conditionally install symfony-freeze package |
| .github/workflows/reusable-codeception-tests-centralized.yaml | Mirrors the freeze detection logic from static analysis workflow and adds logging for branch information |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ling and output clarity
…ing and improve output messages
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bluvulture
left a comment
There was a problem hiding this comment.
lgtm - check does the suggestions from Copilot are valid ones
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
There's something wrong in this logic, it seems that it is always testing on the files on the base branch instead of the files in the PR/branch to be merged. |
|
Extra notes on the noticed an "odd" behavior:
Maybe it's not even this PR, because something happened even before this being merged... the tests were passing on pimcore/pimcore#18809 (which code/pr was wrong) and master 11.5 failed as expected. Added new tests pimcore/pimcore#18814 but not appearing in the codeception run |
|
Also in this PR, any changes before pimcore/pimcore#18814 |
|
Update: all good here, the problem described is not related to this PR, the affected workflow in use is not even the one modified here. That was just a coincidence. We (or better saying Nebojsa) are fixing it. |
This pull request updates the centralized GitHub workflow files to improve how branch-specific logic is handled, especially for installing the
pimcore/symfony-freezepackage based on the target branch. The changes ensure that workflows correctly identify the branch context and conditionally install dependencies, leading to more reliable and predictable CI runs.Branch detection and environment setup:
.github/workflows/reusable-codeception-tests-centralized.yamland.github/workflows/reusable-static-analysis-centralized.yamlto determine the target branch of the workflow run, supporting both pull requests and direct branch runs. The branch name is stored and made available for subsequent steps. [1] [2]Conditional dependency installation:
.x. If not, the workflow installspimcore/symfony-freeze:^6.0and sets an environment variable to indicate the result. This prevents unnecessary installations on maintenance branches and ensures compatibility. [1] [2]Test execution improvements: