Skip to content

[Bug, EC] PEES-842: followup PIMCORE_CLASS_DEFINITON_DIRECTORY setting not applied for brick container classes"#18815

Merged
kingjia90 merged 2 commits into11.5from
revert-18809-fix-brick-container-class
Nov 11, 2025
Merged

[Bug, EC] PEES-842: followup PIMCORE_CLASS_DEFINITON_DIRECTORY setting not applied for brick container classes"#18815
kingjia90 merged 2 commits into11.5from
revert-18809-fix-brick-container-class

Conversation

@kingjia90
Copy link
Copy Markdown
Contributor

@kingjia90 kingjia90 commented Nov 10, 2025

It was wrong ENV in #18809 (probably committed some temporary test change instead of the right fix)

No idea why the tests on the branch were green
https://github.com/pimcore/pimcore/actions/runs/19164917685

@github-actions
Copy link
Copy Markdown

Review Checklist

  • Target branch (11.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@kingjia90
Copy link
Copy Markdown
Contributor Author

still failing, weird, can't be #18709?

@kingjia90
Copy link
Copy Markdown
Contributor Author

might be pimcore/workflows-collection-public#52 ?

@kingjia90 kingjia90 self-assigned this Nov 11, 2025
@kingjia90 kingjia90 added this to the 11.5.13 milestone Nov 11, 2025
@kingjia90 kingjia90 force-pushed the revert-18809-fix-brick-container-class branch from c611fa7 to 6ea9e18 Compare November 11, 2025 09:39
@kingjia90 kingjia90 changed the title Revert "[Bug, EC] PEES-842: PIMCORE_CLASS_DEFINITON_DIRECTORY setting not applied for brick container classes" [Bug, EC] PEES-842: followup PIMCORE_CLASS_DEFINITON_DIRECTORY setting not applied for brick container classes" Nov 11, 2025
@sonarqubecloud
Copy link
Copy Markdown

@kingjia90 kingjia90 merged commit 757f29b into 11.5 Nov 11, 2025
11 of 19 checks passed
@kingjia90 kingjia90 deleted the revert-18809-fix-brick-container-class branch November 11, 2025 09:41
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants