[Bugfix]: use PIMCORE_CUSTOM_CONFIGURATION_CLASS_DEFINITION_DIRECTORY in LocateFileTrait#18709
Merged
kingjia90 merged 1 commit intopimcore:11.5from Nov 7, 2025
Merged
[Bugfix]: use PIMCORE_CUSTOM_CONFIGURATION_CLASS_DEFINITION_DIRECTORY in LocateFileTrait#18709kingjia90 merged 1 commit intopimcore:11.5from
PIMCORE_CUSTOM_CONFIGURATION_CLASS_DEFINITION_DIRECTORY in LocateFileTrait#18709kingjia90 merged 1 commit intopimcore:11.5from
Conversation
Review Checklist
|
|
PIMCORE_CUSTOM_CONFIGURATION_CLASS_DEFINITION_DIRECTORY in LocateFileTraitPIMCORE_CUSTOM_CONFIGURATION_CLASS_DEFINITION_DIRECTORY in LocateFileTrait
Contributor
Author
|
@kingjia90 since you just fixed #18809... maybe you could have a look at this one, too? |
Contributor
|
Thank you for your PR! LGTM by looking at Line 218 in df14e02 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case
PIMCORE_CUSTOM_CONFIGURATION_CLASS_DEFINITION_DIRECTORYis overwritten, usingPIMCORE_CUSTOM_CONFIGURATION_DIRECTORY/classes/would be wrong.