Skip to content

[Bug, EC] PEES-824: Bug: Default Value When Using Field Collections#18814

Merged
kingjia90 merged 17 commits into11.5from
fix-fc-default
Nov 19, 2025
Merged

[Bug, EC] PEES-824: Bug: Default Value When Using Field Collections#18814
kingjia90 merged 17 commits into11.5from
fix-fc-default

Conversation

@kingjia90
Copy link
Copy Markdown
Contributor

@kingjia90 kingjia90 commented Nov 10, 2025

Resolves https://pimcore.atlassian.net/browse/PEES-824, https://github.com/pimcore/service-operations/issues/285
Related pimcore/admin-ui-classic-bundle#1053

Additional info

Added a isUpdate property, relies on resetLanguageDirtyMap(), is null when loading existing data, when setting anything even with emptish values, is an empty array

On frontend, pimcore/admin-ui-classic-bundle#1053 seems working right

@github-actions
Copy link
Copy Markdown

Review Checklist

  • Target branch (11.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@kingjia90 kingjia90 marked this pull request as draft November 10, 2025 17:26
@kingjia90 kingjia90 marked this pull request as ready for review November 17, 2025 08:41
@kingjia90 kingjia90 self-assigned this Nov 19, 2025
@sonarqubecloud
Copy link
Copy Markdown

@kingjia90 kingjia90 merged commit 1ab7773 into 11.5 Nov 19, 2025
19 checks passed
@kingjia90 kingjia90 deleted the fix-fc-default branch November 19, 2025 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants