Skip to content

[Bug, EC] PEES-888: Loss of all relation data in FC after moving DataObjects #18892

Merged
kingjia90 merged 7 commits into11.5from
fix-relations-on-move
Dec 19, 2025
Merged

[Bug, EC] PEES-888: Loss of all relation data in FC after moving DataObjects #18892
kingjia90 merged 7 commits into11.5from
fix-relations-on-move

Conversation

@kingjia90
Copy link
Copy Markdown
Contributor

@kingjia90 kingjia90 commented Dec 17, 2025

Changes in this pull request

Resolves https://pimcore.atlassian.net/browse/PEES-888, https://github.com/pimcore/service-operations/issues/306

Field collection relations might be not fully initialized without forcing it, along with the "problem" that for the relations in a FC are not getting Delta calculated, but they get deleted and reinserted in the DB during update process.

Additional info

Better and even more safer alternative to pimcore/admin-ui-classic-bundle#1070

@kingjia90 kingjia90 added this to the 11.5.14 milestone Dec 17, 2025
@kingjia90 kingjia90 self-assigned this Dec 17, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 17, 2025

Review Checklist

  • Target branch (11.5 for bug fixes, others 12.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@kingjia90 kingjia90 mentioned this pull request Dec 17, 2025
Closed
@kingjia90
Copy link
Copy Markdown
Contributor Author

kingjia90 commented Dec 17, 2025

Tests might need #18887 to work

@bluvulture
Copy link
Copy Markdown
Contributor

bluvulture commented Dec 17, 2025

@kingjia90 we also need adjustment on PHPStan - will update it

@bluvulture
Copy link
Copy Markdown
Contributor

bluvulture commented Dec 17, 2025

#18897 when that one is merged should be okay

@kingjia90
Copy link
Copy Markdown
Contributor Author

kingjia90 commented Dec 18, 2025 •
edited
Loading

dac55ee that change to add force was risky, the handler is sync and could be also async, so forcing lead to unwanted behavior that triggered a lot of test errors, so keeping the update() only

@kingjia90 kingjia90 merged commit 548c4a9 into 11.5 Dec 19, 2025
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2025
@kingjia90 kingjia90 deleted the fix-relations-on-move branch December 19, 2025 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@kingjia90 kingjia90

Labels

Bug Pimcore:Priority

Projects

None yet

Milestone

11.5.14

Development

Successfully merging this pull request may close these issues.

3 participants

@kingjia90 @bluvulture @fashxp