Conversation
Review Checklist
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR separates PHPStan static analysis workflows for different major versions of Pimcore by creating a dedicated workflow for the 11.x branch while restricting the existing workflow to only run on 12.x branches.
Key changes:
- Restricts the existing static analysis workflow to run only on 12.* branches
- Creates a new workflow specifically for 11.x branches with PHP 8.1-8.3 support
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/static-analysis.yaml |
Updates branch patterns from wildcard patterns to specifically target only "12.*" branches |
.github/workflows/static-analyisis-11x.yaml |
New workflow file for running PHPStan on 11.x branches with appropriate PHP versions (8.1-8.3) and dependencies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
PHPStan for 11.x
Additional info