Conversation
Review Checklist
|
There was a problem hiding this comment.
Pull request overview
This PR adds a new GitHub Actions workflow configuration for running Codeception tests specifically for the 11.x branch family. The workflow is designed to handle the changes announced in the GitHub blog post regarding pull_request_target and environment branch protections.
Key Changes:
- Introduces a dedicated Codeception workflow for 11.x maintenance branches
- Configures matrix testing across PHP 8.1, 8.2, and 8.3 with various database combinations
- Uses the centralized reusable workflow pattern already established in the repository
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
| - "11.5" | ||
| paths-ignore: | ||
| - 'doc/**' | ||
| - 'bundles/**/public/**' | ||
| push: | ||
| branches: | ||
| - "11.*" | ||
| - "11.5" |
There was a problem hiding this comment.
The branch pattern "11.5" doesn't match the pattern "11.". The "11.5" pattern will only match exactly "11.5", while "11." will match "11.0", "11.1", etc. but not "11.5" itself. Either use "11.[0-9]+" or list specific branches like "11.4", "11.5", "11.6".
| - "11.5" | |
| paths-ignore: | |
| - 'doc/**' | |
| - 'bundles/**/public/**' | |
| push: | |
| branches: | |
| - "11.*" | |
| - "11.5" | |
| paths-ignore: | |
| - 'doc/**' | |
| - 'bundles/**/public/**' | |
| push: | |
| branches: | |
| - "11.*" |
| - 'doc/**' | ||
| - 'bundles/**/public/**' | ||
| permissions: | ||
| contents: read |
There was a problem hiding this comment.
The permissions block should be followed by a blank line for consistency with the existing codeception.yaml file and standard YAML formatting practices. Currently missing a blank line between line 19 and line 20.
| contents: read | |
| contents: read |
kingjia90
left a comment
There was a problem hiding this comment.
LGTM, and can be easily reverted (deleting the 11.x specific workflow) once Github fixes it
Changes in this pull request
See here https://github.blog/changelog/2025-11-07-actions-pull_request_target-and-environment-branch-protections-changes/#what-is-changing
Additional info