Skip to content

[Task]: Temporary revert cbschuld/browser.php requirement#14883

Closed
kingjia90 wants to merge 1 commit into11.xfrom
restore-cbschuld-browser
Closed

[Task]: Temporary revert cbschuld/browser.php requirement#14883
kingjia90 wants to merge 1 commit into11.xfrom
restore-cbschuld-browser

Conversation

@kingjia90
Copy link
Copy Markdown
Contributor

@kingjia90 kingjia90 commented Apr 6, 2023

Related #14876
Needs to be removed once the AdminBundle is extracted and removed from repo #12531

Additional info

WHAT

🤖 Generated by Copilot at c56153f

Added the cbschuld/browser.php package as a dependency in composer.json to enable browser detection in pimcore. This change is part of a pull request that aims to resolve issue #10312.

🤖 Generated by Copilot at c56153f

composer.json
Updated for browser.php
A winter feature

HOW

🤖 Generated by Copilot at c56153f

  • Add browser detection functionality to pimcore using the cbschuld/browser.php package (link)

@kingjia90 kingjia90 added the Task label Apr 6, 2023
@kingjia90 kingjia90 added this to the 11.0.0 milestone Apr 6, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2023

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@dvesh3
Copy link
Copy Markdown
Contributor

dvesh3 commented Apr 7, 2023

Closed in favor of #14885

@dvesh3 dvesh3 closed this Apr 7, 2023
@dvesh3 dvesh3 removed this from the 11.0.0 milestone Apr 7, 2023
@kingjia90 kingjia90 deleted the restore-cbschuld-browser branch April 7, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants