Conversation
Review Checklist
|
Contributor
|
Mhh, just came up to my mind that we cannot remove from the main composer yet, because it doesn't install the one in subfolders like AdminBundle, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #9357 (comment)
Additional info
WHAT
🤖 Generated by Copilot at 51df536
Simplified and improved the dependency management of the
pimcore/pimcorepackage and its sub-bundles. Removed some redundant or conflicting dependencies, and added one missing dependency for theAdminBundle.🤖 Generated by Copilot at 51df536
HOW
🤖 Generated by Copilot at 51df536
composer.json(link, link, link)cbschuld/browser.phpdependency tobundles/AdminBundle/composer.jsonwhere it is used for browser detection (link, link)masterminds/html5dependency withsymfony/dom-crawlerfor HTML parsing (link)symfony/assetfromsymfony-require-dev.shscript to avoid conflicts or updates (link)