Skip to content

Fix Routing issue - re-add doctrine/annotations required for fosjsrouting#14885

Merged
kingjia90 merged 1 commit into11.xfrom
fix_routing_issue
Apr 7, 2023
Merged

Fix Routing issue - re-add doctrine/annotations required for fosjsrouting#14885
kingjia90 merged 1 commit into11.xfrom
fix_routing_issue

Conversation

@dvesh3
Copy link
Copy Markdown
Contributor

@dvesh3 dvesh3 commented Apr 7, 2023 •
edited by ghost
Loading

Changes in this pull request

Resolves #

Additional info

WHAT

🤖 Generated by Copilot at 99a63b7

This pull request enhances the admin interface and the data model with browser detection and data object annotations. It adds cbschuld/browser.php and doctrine/annotations as new dependencies in composer.json.

🤖 Generated by Copilot at 99a63b7

Oh we're the coders of the seven seas
We write the features that the admins please
We pull the composer.json on the count of three
And we add the browser and the annotations dependencies

HOW

🤖 Generated by Copilot at 99a63b7

  • Add cbschuld/browser.php and doctrine/annotations packages as dependencies to enable browser detection and annotation parsing (link, link in composer.json)

@dvesh3 dvesh3 added the Bug label Apr 7, 2023
@dvesh3 dvesh3 added this to the 11.0.0 milestone Apr 7, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2023

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@dvesh3 dvesh3 mentioned this pull request Apr 7, 2023
Closed
@dvesh3 dvesh3 requested a review from kingjia90 April 7, 2023 06:44
@kingjia90 kingjia90 merged commit b92d7c5 into 11.x Apr 7, 2023
@kingjia90 kingjia90 deleted the fix_routing_issue branch April 7, 2023 06:51
@matthiashamacher matthiashamacher mentioned this pull request Apr 16, 2023
Merged
brusch
brusch reviewed Apr 17, 2023
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brusch brusch brusch left review comments

@kingjia90 kingjia90 Awaiting requested review from kingjia90

Assignees

@kingjia90 kingjia90

Labels

Bug

Projects

None yet

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dvesh3 @brusch @kingjia90