Replace all structure body comments with simple ellipsis#79
Merged
Crell merged 1 commit intophp-fig:masterfrom Jun 6, 2023
Merged
Replace all structure body comments with simple ellipsis#79Crell merged 1 commit intophp-fig:masterfrom
Crell merged 1 commit intophp-fig:masterfrom
Conversation
- Capitalize beginning of all comments - No periods at the end of comments As an alternative to php-fig#75.
Crell
approved these changes
Jun 5, 2023
Collaborator
|
An informal poll in the WG Discord overwhelmingly favored this version, so we'll go with it. Thanks. |
vdelau
added a commit
to vdelau/per-coding-style
that referenced
this pull request
May 13, 2025
In [PR 79](php-fig#79) all comments where either replaced with ellipsis or capitalized. The `// no break` comment however is used literally in various tools and capitalizing this might lead to tooling regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an alternative to #75.