Closed
Conversation
- Capitalize beginning of all comments (regardless of keyword usage)
- Replace "..." with "{context} body"
- Use comment wording consistently & be specific for each use case
- No periods or ellipses at the end of comments
Crell
approved these changes
Jun 1, 2023
KorvinSzanto
reviewed
Jun 1, 2023
Contributor
|
I agree these comments can be cleaned up and it might be good to do so. I'm not sure I agree with the choices here though, to me the |
samdark
approved these changes
Jun 2, 2023
Member
samdark
left a comment
There was a problem hiding this comment.
👍 except @KorvinSzanto comments
ravage84
added a commit
to ravage84/per-coding-style
that referenced
this pull request
Jun 5, 2023
- Capitalize beginning of all comments - No periods at the end of comments As an alternative to php-fig#75.
Contributor
Author
|
I created an alternative to this PR that replaces all strucutre body comments with ellipsis: #79 |
Collaborator
|
Merged #79 instead, so closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll admit, this is nitpicking but it helps to think less about the comments when reading the specification.