@keradus @bshaffer

Please take a look.

how do you set the path to your src?

@bshaffer

Actually, you don't need to set the src path at all. phpunit knows which files to measure the coverage, and coveralls will remove the project dir's full path from the files, then report relative paths of the files to coveralls.

So RootDir is now more important. We are going to change the RootDir detection with #124 FYI.

@bshaffer
FYI, this commit:
2fbf803

makes src_dir orphaned. I confirmed this with @satooshi so I'm 100% sure :)

that's great! LGTM

Alright, I'll wait @keradus for his review

We still need to keep it in CoverallsConfiguration for compatibility.

1. please, send PR with that change which breaks BC
2. project does not released v1.0, then all BC breaks aren't considered as BC breaks.

@keradus Hm, but I don't want to receive many issues with errors about 'src_dir'. I'll include a notice in the changelog with the next release 0.7 and I'll remove that entirely in the release after that 0.8 (or 0.7.1).

That is why I have asked for second PR in the first place.
It is common to have not only one current version. You can have fev branches, like 0.7, 0.8 and master (aliased to 1.0-dev).

@keradus
The second pull request will just fail without this change. Let me create the second one after merging this.

Re: branches, yeah, I will definitely create 0.7.0 branch when we release it.

0.7, no sense to create branch wich patch version in name.

true

@keradus
Does the change look good?

dunno, still waiting for creating second branch for which you will send second PR.
That two PRs should be reviewed in same time.

@keradus

I don't think it's worthwhile to create that branch now, but I created another PR for removing src_dir from CoverallsConfiguration at #136

Please take a look.

@keradus
Alright, removed un-used $srcDir from the test helper. Please take another look.

👍

@keradus Thanks for the review. I just squashed the commits and will merge once travis builds become all green. BTW travis is in weird state, no builds started.

try to disable push hook and see then

Tried several things, restart, disabling push hook, etc, but no luck yet.
Filed: travis-ci/travis-ci#5240

I'm going to start setting CircleCI builds. CircleCI is anyways a big service that we want to support, so it makes sense to set it up anyways.

I can convirm that Travis has some problem today. On .com version too.
CircleCI as addition to Travis or replacement?

I'm thinking just an addition

👍 for addition

It turned out that it's kinda difficult to get build matrix on CircleCI so I'm going to pick one environment. I'm thinking to have 5.3.3 with --prefer-lowest --prefer-stable.

What do you think?

First say why you want to use CircleCI.? Way of usage depends on what you need.

Yeah, for short term, I want to get sanity by seeing green builds. For a longer term, I want to make sure our CircleCI support is working.

For first reason - as long as Travis will run all PHP version it is ok to have only one PHP version on CircleCI.
For second reason - yeah, one PHP is enough

Travis is back to normal. Merging this.

Thanks for the review @keradus !