Skip to content

Removed src_dir from CoverallsConfiguration.#136

Merged
tmatsuo merged 1 commit intophp-coveralls:masterfrom
tmatsuo:remove-src-dir
Dec 25, 2015
Merged

Removed src_dir from CoverallsConfiguration.#136
tmatsuo merged 1 commit intophp-coveralls:masterfrom
tmatsuo:remove-src-dir

Conversation

@tmatsuo
Copy link
Collaborator

@tmatsuo tmatsuo commented Dec 6, 2015

This change will go into the v0.8 release. Don't merge for v0.7 line.

@tmatsuo tmatsuo modified the milestones: v0.7, v0.8 Dec 7, 2015
@tmatsuo
Copy link
Collaborator Author

tmatsuo commented Dec 8, 2015

Rebased, so it should pass the tests

@tmatsuo
Copy link
Collaborator Author

tmatsuo commented Dec 8, 2015

Oops. I needed to remove src_dir from the test yaml files.

@tmatsuo tmatsuo changed the title Removed src_dir from CoverallsConfiguration. [Do not merge until v0.8] Removed src_dir from CoverallsConfiguration. Dec 8, 2015
@keradus
Copy link
Member

keradus commented Dec 10, 2015

0.7 is still not released.

I can not understand why yo dont want to merge it into 0.7 ?

@tmatsuo
Copy link
Collaborator Author

tmatsuo commented Dec 10, 2015

Because this is a breaking change. The old config files wil trigger an error.

@keradus
Copy link
Member

keradus commented Dec 10, 2015

And then, current version is 0.6. And you want to release 0.7. And that version change allows you to make BC breaks.

@tmatsuo
Copy link
Collaborator Author

tmatsuo commented Dec 10, 2015

Strictly saying, that's true, but because it's been a while from the last stable release, I assume many people are using dev-master. If we merge this, their build will break. I would release 0.7.0 and start encouraging using that stable version, then will introduce breaking change in 0.8.0.

@keradus
Copy link
Member

keradus commented Dec 10, 2015

If sb using dev-master he is asking for it :D But I can accept that.

BTW, 0.7 won't be stable version... stable will be 1.0.

@tmatsuo
Copy link
Collaborator Author

tmatsuo commented Dec 10, 2015

Ya, right.

@tmatsuo
Copy link
Collaborator Author

tmatsuo commented Dec 17, 2015

Rebased

@tmatsuo
Copy link
Collaborator Author

tmatsuo commented Dec 25, 2015

This change will go into 1.0.0 release. @keradus Do you want to take a look or is it good to merge?

@Taluu
Copy link

Taluu commented Dec 25, 2015

I think you should keep it for 0.8 (as @keradus said, if somebody is using dev-master, they're asking for it) but meh, it looks good though.

@keradus
Copy link
Member

keradus commented Dec 25, 2015

👍

@tmatsuo tmatsuo changed the title [Do not merge until v0.8] Removed src_dir from CoverallsConfiguration. Removed src_dir from CoverallsConfiguration. Dec 25, 2015
@tmatsuo
Copy link
Collaborator Author

tmatsuo commented Dec 25, 2015

Thanks @keradus and @Taluu

Merging

tmatsuo pushed a commit that referenced this pull request Dec 25, 2015
Removed src_dir from CoverallsConfiguration.
@tmatsuo tmatsuo merged commit 73d05ac into php-coveralls:master Dec 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants