Removed src_dir from CoverallsConfiguration.#136
Removed src_dir from CoverallsConfiguration.#136tmatsuo merged 1 commit intophp-coveralls:masterfrom
Conversation
72e0748 to
f81e4f8
Compare
|
Rebased, so it should pass the tests |
|
Oops. I needed to remove src_dir from the test yaml files. |
|
0.7 is still not released. I can not understand why yo dont want to merge it into 0.7 ? |
|
Because this is a breaking change. The old config files wil trigger an error. |
|
And then, current version is 0.6. And you want to release 0.7. And that version change allows you to make BC breaks. |
|
Strictly saying, that's true, but because it's been a while from the last stable release, I assume many people are using dev-master. If we merge this, their build will break. I would release 0.7.0 and start encouraging using that stable version, then will introduce breaking change in 0.8.0. |
|
If sb using dev-master he is asking for it :D But I can accept that. BTW, 0.7 won't be stable version... stable will be 1.0. |
|
Ya, right. |
d763a6b to
accb02a
Compare
|
Rebased |
accb02a to
ab3c764
Compare
6d319a6 to
eb8b6e2
Compare
|
This change will go into 1.0.0 release. @keradus Do you want to take a look or is it good to merge? |
|
I think you should keep it for 0.8 (as @keradus said, if somebody is using dev-master, they're asking for it) but meh, it looks good though. |
|
👍 |
Removed src_dir from CoverallsConfiguration.
This change will go into the v0.8 release. Don't merge for v0.7 line.