feat!: Add support for specifying rankdir on dot plots. #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
Collaborator
|
Hi @volodymyrd, please rebase and resolve conflicts. |
# Conflicts: # src/dot.rs
Contributor
Author
|
Hi @starovoid done |
starovoid
requested changes
Mar 24, 2025
Collaborator
starovoid
left a comment
There was a problem hiding this comment.
Please fix the following warning from clippy:
error: this URL is not a hyperlink
--> src/dot.rs:100:5
|
100 | /// https://graphviz.org/docs/attrs/rankdir/
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: bare URLs are not automatically turned into clickable links
= note: `-D rustdoc::bare-urls` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(rustdoc::bare_urls)]`
help: use an automatic link instead
|
100 | /// <https://graphviz.org/docs/attrs/rankdir/>
| + +
Contributor
Author
|
done |
Collaborator
Workflow uses more detailed checks: - name: Run clippy
# The benchmarks target require nightly,
# so we cannot use --all-targets here.
run: |
cargo clippy --all-features \
--lib --bins --examples --tests \
-- -D warnings
- name: Build docs
run: cargo doc --no-deps --all-features
env:
RUSTDOCFLAGS: "-Dwarnings" |
Collaborator
|
Finally, please squash all commits into new one to simplify commits history. git reset $(git merge-base master $(git branch --show-current))
git add -A
git commit -m "Add support for specifying rankdir on dot plots"
git push --force |
ABorgna
reviewed
Mar 24, 2025
Comment on lines
132
to
133
| #[doc(hidden)] | ||
| _Incomplete(()), |
Member
There was a problem hiding this comment.
Since we're doing a breaking change adding this already, can you add #[non_exhaustive] to the enum?
And remove this workaround:
Suggested change
| #[doc(hidden)] | |
| _Incomplete(()), |
Member
No need for that, the merge queue will automatically squash and rebase :) |
starovoid
approved these changes
Mar 24, 2025
Contributor
Author
|
Should I merge the changes? |
Member
|
Let's merge it, I'll add the enum flag in a separate PR |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
Removes the TODO as mentioned in #728 BREAKING CHANGE: Marked `dot::Enum` as `non_exhaustive`
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 5, 2025
A sufficient number of proposed changes have accumulated to combine them and publish a new major release numbered `0.8.0`. BREAKING CHANGE: This will require the user to provide extra type parameter in some APIs (Read more in #747). ## List of changes - [x] #747 The main innovation of the current release, the long-awaited feature that has become very relevant due to the transition of dependent projects to support `no_std`. - [x] #662 - [x] #611 - [x] #728 - [x] #686 - [x] #737 - [x] #720 - [x] #718 ## Note There are still a large number of PRs that we want to adopt in the near future, so we should expect at least a release of `0.8.1` soon after the completion of `0.8.0`. Thank you all for participating! --------- Co-authored-by: Agustin Borgna <agustinborgna@gmail.com>
This was referenced Apr 5, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends Config for rankdir support - direction of graph layout.
BREAKING CHANGE:
Add new variant of public enum
dot::Config.