feat!: Add VisitMap::unvisit as proposed in #610
#611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VisitMap::unmark as proposed in #610VisitMap::unvisit as proposed in #610
bluss
reviewed
Mar 1, 2024
src/visit/mod.rs
Outdated
| /// | ||
| /// Return **true** if this vertex was marked as visited at the time of unsetting it, false otherwise. | ||
| fn unvisit(&mut self, _a: N) -> bool { | ||
| unimplemented!("We don't know how to mark the node as unvisited.") |
Member
There was a problem hiding this comment.
Could it be avoided to have a default implementation? Instead leave this out and let it be a breaking change, that's the principled approach at least.
Contributor
Author
There was a problem hiding this comment.
Yeah we could totally get by without a default implementation. My initial idea was to not make this a breaking change but an additional feature that is backwards compatible. I don't have a strong preference but if breaking change is preferable, then lets go ahead with that.
Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
Contributor
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
VisitMap::unvisit as proposed in #610VisitMap::unvisit as proposed in #610
starovoid
approved these changes
Mar 21, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 5, 2025
A sufficient number of proposed changes have accumulated to combine them and publish a new major release numbered `0.8.0`. BREAKING CHANGE: This will require the user to provide extra type parameter in some APIs (Read more in #747). ## List of changes - [x] #747 The main innovation of the current release, the long-awaited feature that has become very relevant due to the transition of dependent projects to support `no_std`. - [x] #662 - [x] #611 - [x] #728 - [x] #686 - [x] #737 - [x] #720 - [x] #718 ## Note There are still a large number of PRs that we want to adopt in the near future, so we should expect at least a release of `0.8.1` soon after the completion of `0.8.0`. Thank you all for participating! --------- Co-authored-by: Agustin Borgna <agustinborgna@gmail.com>
This was referenced Apr 5, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the
VisitMap::unvisitmethod as proposed in #610 .BREAKING CHANGE:
Add new method to existing trait.