Merged
Conversation
4afcd6b to
686a4f0
Compare
Robdel12
approved these changes
Jun 17, 2021
Contributor
Robdel12
left a comment
There was a problem hiding this comment.
No need for 🚲 🏠 , I dig it. Nice 🏁
- Default concurrency to 10 - Rename pause() to stop() - Add ability for close() to abort - Abort queue when closing the Percy instance - Catch sync errors when running queued tasks
While testing Storybook and sending a SIGTERM event, I noticed that there were occasional unhandled promise rejections caused by page/browser closed errors bubbling from random event callbacks. The closed errors always bubble and get raised from other methods, so in these few unhandled rejections, we can simply log a debug message to handle it.
686a4f0 to
1a4acea
Compare
samarsault
pushed a commit
that referenced
this pull request
Mar 3, 2023
Bumps [@cypress/code-coverage](https://github.com/cypress-io/code-coverage) from 3.9.7 to 3.9.8. - [Release notes](https://github.com/cypress-io/code-coverage/releases) - [Commits](cypress-io/code-coverage@v3.9.7...v3.9.8) --- updated-dependencies: - dependency-name: "@cypress/code-coverage" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
Following #369 and subsequently #372, I've since found a couple other minor thing that need to be tweaked.
In agent, up to 10 browser pages were pooled to be running at once. It was lowered in the CLI since moving to a proper queue with a concurrency. Now that queue performance has gotten much better, let's up it to 10 again. Even in previous versions of the CLI up to 10 browser pages could be running when using the capture method, so being able to set this more accurately is a win from ♻️ Refactor core discovery queue #369.
Rename
queue.pause()toqueue.stop()(🚲 🏠). Pause implies that there is still more to run, while stop implies that it won't run regardless if there is more to run. Stop also feels more complimentary torun().Add ability for
close()to abort. This will stop and clear the queue while closing it, exactly what is really needed by thepercy.close()method.Abort queue when force stopping the Percy instance. Rather than clear the queues which will be closed, when force stopping we can utilize
percy.close()to wholesale abort any currently queued tasks.Catch sync errors when running queued tasks. While wrapping the dequeued callback in a resolve served to catch async errors, sync errors could still happen which would cause pending tasks to never be cleared.
While testing Storybook and sending a SIGTERM event, I noticed that there were occasional unhandled promise rejections caused by page/browser closed errors bubbling from random event callbacks. The closed errors always bubble and get raised from other methods, so in these few unhandled rejections, we can simply log a debug message to handle it. Coverage was skipped for these catches since they all only occur in specific race conditions.