🐛 Fix unintentionally removing the default queue concurrency#372
Merged
🐛 Fix unintentionally removing the default queue concurrency#372
Conversation
Robdel12
approved these changes
Jun 17, 2021
Contributor
Robdel12
left a comment
There was a problem hiding this comment.
This enables infinite concurrency which is not what we want since it causes a huge slowdown as more and more resources are consumed in parallel
🏖️ 🏀 hahahah
🏁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
With recent changes from #369, when
config.discovery.concurrencyis not defined, it is still being set on the queue causing the default of 5 to be removed. This enables infinite concurrency which is not what we want since it causes a huge slowdown as more and more resources are consumed in parallel