#ifdef CRUX macros removed. Percolator no longer produces output for …#340
Merged
percolator merged 2 commits intopercolator:masterfrom Aug 22, 2022
Merged
#ifdef CRUX macros removed. Percolator no longer produces output for …#340percolator merged 2 commits intopercolator:masterfrom
percolator merged 2 commits intopercolator:masterfrom
Conversation
percolator
reviewed
Aug 22, 2022
Owner
percolator
left a comment
There was a problem hiding this comment.
These edits effect sections under #ifdef CRUX and should have no effect on the regular compilation of percolator.
percolator
added a commit
to statisticalbiotechnology/percolator
that referenced
this pull request
Jan 10, 2023
percolator#340) (#2) * #ifdef CRUX macros removed. Percolator no longer produces dedicated output for CRUX. Co-authored-by: Attila -- Kertesz-Farkas <kfattila@yandex.com>
percolator
added a commit
that referenced
this pull request
May 31, 2024
* Adding Percolator-RESET as an experimental feature * Added checks for number of decoy PSMs<=1 (#337) * Removing multiple warnings of decoyPrefix not being set (despite being set). (#338) * #ifdef CRUX macros removed. Percolator no longer produces output for … (#340) (#2) * Buildscript compatibility with Ubuntu 22.04 and higher * fixing column header case sensitivity error * Removing all Fido code * Adding support for c++14 * Removing centos binaries (distribution discontinued)
percolator
added a commit
that referenced
this pull request
May 26, 2025
* Removing some sources of repeated warnings about missing decoyPrefixes in protein names * Added checks for number of decoy PSMs<=1 (#337) * Removing multiple warnings of decoyPrefix not being set (despite being set). (#338) * Removing some sources of repeated warnings about missing decoyPrefixes in protein names * #ifdef CRUX macros removed. Percolator no longer produces output for … (#340) (#2) * Jan bugfix (#3) * Buildscript compability with ubuntu 22.04 and higher * fixing column header case sensitivity error * New class for isotonic regression of PEP values. * Receipe for container deployment in ghcr * debugging * Added options for isotonic regression. * Added Ispline code. * Some speedups and optimizations. Added Unit Tests. * Forcing package manager to homebrew * added libtirpc-dev to ubuntu builder * bumping macos runner version * updating Boost.Asio interface * removing GoogleAnalytics for now, * just remoce .cmake for py and h files. * tackling _finite in Eigen. --------- Co-authored-by: Attila -- Kertesz-Farkas <kfattila@yandex.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the #ifder CRUX macros. Percolator, when called from CRUX, no longer parses and converts percolator's output for CRUX eco system. Three files changes, (Caller.cpp, Caller.h, Scores.cpp), the source code compiles.