Fix export test failure to unrevert #8370#8380
Merged
cosmicexplorer merged 2 commits intopantsbuild:masterfrom Oct 2, 2019
Merged
Fix export test failure to unrevert #8370#8380cosmicexplorer merged 2 commits intopantsbuild:masterfrom
cosmicexplorer merged 2 commits intopantsbuild:masterfrom
Conversation
wisechengyi
approved these changes
Oct 2, 2019
illicitonion
pushed a commit
that referenced
this pull request
Oct 3, 2019
cosmicexplorer
added a commit
to cosmicexplorer/pants
that referenced
this pull request
Oct 4, 2019
…antsbuild#8380)" (pantsbuild#8386)" This reverts commit d2bf825.
cosmicexplorer
added a commit
that referenced
this pull request
Oct 4, 2019
…8389) ### Problem See #8370. This PR fixes an integration test failure which required reverting in #8379, then we attempted to unrevert in #8380, then was reverted again in #8386. ### Solution - Remove the `--ivy-cache-dir` arguments from the export task invocation in the export integration test. ### Result The test passes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8370 was merged without passing all tests (which broke master) and was reverted in #8379. This fixes the failing test by injecting the
//:scalac_2_12target which is necessary for the test using scala 2.12 to successfully ready the scala compiler jars.