Fix export test by removing ivy cache settings to un-unrevert #8370#8389
Merged
cosmicexplorer merged 4 commits intopantsbuild:masterfrom Oct 4, 2019
Conversation
stuhood
approved these changes
Oct 4, 2019
Member
stuhood
left a comment
There was a problem hiding this comment.
Thanks!
Looks good, although there is one test failure.
Contributor
Author
|
CI is failing only on known flaky tests -- the single failure in https://travis-ci.org/pantsbuild/pants/jobs/593612801 is likely not related to this change, and I have started a thread on this failure in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
See #8370. This PR fixes an integration test failure which required reverting in #8379, then we attempted to unrevert in #8380, then was reverted again in #8386.
Solution
--ivy-cache-dirarguments from the export task invocation in the export integration test.Result
The test passes!