Enforce flake8 E741#22795
Merged
WillAyd merged 1 commit intopandas-dev:masterfrom Sep 20, 2018
alimcmaster1:flake8
Merged
Conversation
Enforce E741
Member
|
+1 |
Member
|
Simple enough and Travis passed so I'll take @jbrockmendel 's +1 as approval to merge :-) Thanks @alimcmaster1 |
Member
Author
|
Thanks! @WillAyd |
6 tasks
Codecov Report
@@ Coverage Diff @@
## master #22795 +/- ##
=======================================
Coverage 92.18% 92.18%
=======================================
Files 169 169
Lines 50804 50804
=======================================
Hits 46833 46833
Misses 3971 3971
Continue to review full report at Codecov.
|
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce flake8 E741
#19496 ( Was added here )
But running
flake8 --select E741returns nothingLooks like this is a valid flake8 rule: ( unless im looking at the wrong docs )
https://lintlyci.github.io/Flake8Rules/