Added E741 to flake8 config#19496
Merged
jreback merged 2 commits intopandas-dev:masterfrom Feb 2, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19496 +/- ##
==========================================
+ Coverage 91.67% 91.7% +0.02%
==========================================
Files 148 148
Lines 48553 48553
==========================================
+ Hits 44513 44525 +12
+ Misses 4040 4028 -12
Continue to review full report at Codecov.
|
Contributor
|
no the excepts should be fixed (there is an issue) |
Contributor
|
thanks! |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Member
|
Hey - out of interest how come we ignore this error (E741) I don't see any instances of it in the codebase and thinking we could now enforce it? |
Contributor
Author
|
Not sure. I may have copied it from another config (this came from updates
to flake8's rules).
…On Tue, Sep 18, 2018 at 7:43 PM alimcmaster1 ***@***.***> wrote:
Hey - out of interest how come we ignore this error (E741) I don't see any
instances of it in the codebase and thinking we could now enforce it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19496 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIiVVWEoQ0d9m8AUAgg-VgNOtkqReks5ucZMWgaJpZM4R2R8b>
.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes this easier to run locally.
Do we want to ignore bare exception (E722) too? Or is the hope that we'll fix all those eventually?