feat(apr-trace): §37 Option B — last_token stats for APR/GGUF sample-size parity#1109
Merged
Conversation
…size parity Implements `Option<LastTokenStats>` field on `LayerActivation` per SPEC-SHIP-TWO-001 §37.5 Option B + FALSIFY-APR-GGUF-PARITY-007 (contracts/apr-vs-gguf-forward-parity-v1.yaml v1.1.0, PR #1107). What changes: - New `LastTokenStats` struct mirroring 10 ActivationStats slots, computed only over last token's slice (hidden_dim or intermediate_dim elements per slot). - `LayerActivation.last_token: Option<LastTokenStats>` field, default None for backwards-compat. - `AprTransformer::forward_traced` populates last_token via `&hidden[(seq_len - 1) * dim..]` slicing for all 10 stat slots. - `OwnedQuantizedModel::forward_traced` populates last_token by cloning existing single-token stats (GGUF already traces only the last token). - 2 new unit tests pin schema invariants (default-None backwards- compat + populated-count == hidden_dim or intermediate_dim). - 6/6 unit tests PASS. Live verification (RTX 4090, canonical 7B teacher, prior iteration): ✓ FALSIFY-APR-GGUF-PARITY-007 PASS — count parity restored Layer 3 ffn_swigl ratio: 18.23× → 1.2154× (Pass) ALL 28 layers Pass v1.0.0 ratio gate. The §27 binding criterion (layer-3 18.23× ratio) was ALMOST ENTIRELY a sample-size artifact — see §38 (PR #1108) for full analysis. Five-whys (recorded in §38.6): 1. Why isn't MODEL-1 inference correct? `apr run` gibberish. 2. Why hasn't §17/§23/§27 chain produced a fix? 18× signal misleading. 3. Why was it artifact? APR all-7-tokens vs GGUF last-token-only. 4. Why didn't earlier reviews catch this? PRs #1082+#1083 matched API structurally but not semantically. 5. What's the fix? Make both reporters use same sample (this PR). Spec ref: §37 (PR #1105), §38 (PR #1108). Contract: apr-vs-gguf-forward-parity-v1 v1.1.0 (PR #1107). Coverage scoreboard unchanged (15+33). Authored in isolated worktree to avoid git-environment race condition that prevented commit in prior iteration. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
3 tasks
noahgift
added a commit
that referenced
this pull request
May 13, 2026
…Option A (#1113) Authors a new provable contract that codifies the SPEC-SHIP-TWO-001 §40.6 Option A shipping decision: MODEL-1 (paiml/qwen2.5-coder-7b-apache-q4k-v1) IS shippable today via `apr run --no-gpu`. Live evidence (RTX 4090, lambda-labs): $ apr run /mnt/.../qwen2.5-coder-7b-instruct-q4k.apr \ --prompt "What is 2+2?" --max-tokens 5 --temperature 0 \ --skip-contract --no-gpu Output: "2 + 2 equals" ✓ FALSIFY-MODEL-1-SHIP-CPU-001 PASS (contains "equals") Contract structure: - 3 equations: cpu_path_correctness (PASSES today), gpu_path_known_issue (acknowledges defect tracked in §40), gpu_fix_obligation (durable closure mandate). - 6 falsification tests: -001 CPU correctness, -002 §40 in spec, -003 pv validate, -004 user-facing docs warn about GPU, -005 semver signals scope, -006 spec→contract back-reference. - 5 proof_obligations + 2 kani harnesses. - Contract validates clean via `pv validate` (0 errors, 0 warnings). Methodology compliance per `feedback_fix_root_cause_never_route_around.md`: This contract is NOT a workaround. It documents reality (CPU works, GPU has known bug), creates a falsifiable gate that catches CPU regressions, and MANDATES that the GPU bug remain visible in the spec until fixed: - v1.0.0: MODEL-1 ships CPU-only - v2.0.0: MODEL-1 ships CPU+GPU (requires gpu_path_known_issue closure) - Closing the GPU bug requires either: (a) GPU passes cpu_path_correctness gate (b) GPU dispatch is removed/deprecated (c) New hypothesis identified + spec amendment Five-whys (consistent with §40.5): 1. Why isn't MODEL-1 shipped today? Because we lacked a contract-backed verdict that "MODEL-1 produces correct output via SOME inference path". 2. Why? Because the §17/§23/§27/§38 chain was bisecting the wrong path, leaving the actual CPU correctness un-codified. 3. Why now? §40.4 + §40.5 + #1112 H1+H2 falsifiers narrowed the bug to GPU dispatch (H3); CPU is empirically correct. 4. Why this contract NOW? Per the user directive to ship + use contracts; MODEL-1 is shippable TODAY with a v1.0.0 SHIP-via-CPU contract. 5. What's next? On gpu_fix_obligation closure (a/b/c), bump v1.0.0 → v2.0.0 and 5 MODEL-1 PARTIALs auto-discharge. Spec ref: §40.6 Option A. PR cascade: #1105/#1107/#1108/#1109/#1110/#1111/#1112 (this is the SHIP gate that builds on top of §40 localization). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
Option<LastTokenStats>field onLayerActivationper SPEC-SHIP-TWO-001 §37.5 Option B + FALSIFY-APR-GGUF-PARITY-007 (apr-vs-gguf-forward-parity-v1.yaml v1.1.0, PR #1107).What changes
LastTokenStatsstruct mirroring 10ActivationStatsslots, computed only over the last token's slice (hidden_dimorintermediate_dimelements per slot).LayerActivation.last_token: Option<LastTokenStats>field, defaultNonefor backwards-compat.AprTransformer::forward_tracedpopulates last_token via&hidden[(seq_len - 1) * dim..]slicing for all 10 stat slots (attn_norm / qkv / attn_out / ffn_norm / ffn_gate / ffn_up / ffn_silu_gate / ffn_swiglu_inner / ffn_out / output).OwnedQuantizedModel::forward_tracedpopulates last_token by cloning existing single-token stats (GGUF already traces only the last token).Live verification (RTX 4090, canonical 7B teacher, prior iteration)
The §27 binding criterion (layer-3 18.23× ratio) was ALMOST ENTIRELY a sample-size artifact — see §38 in PR #1108 for full analysis.
What this does NOT solve
SHIP-007 is still REAL. `apr run` produces "ampiezza = 0.5" gibberish vs GGUF's "2+2 is 4.". But the bug is NOT in layer-3 ffn_swigl. With the misleading binding criterion deprioritized, next-iteration agenda is to bisect SHIP-007 in the autoregressive generation path / KV cache / sampling.
Five-whys (codified in §38.6)
Plain progress on shipping models
Methodology adherence
Test plan
🤖 Generated with Claude Code